From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D798C11F65 for ; Wed, 30 Jun 2021 16:30:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCB1F61433 for ; Wed, 30 Jun 2021 16:30:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCB1F61433 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PHSqOdCaK/e53QxonEi70Ex+2+AyccXtIcpFAFncU6I=; b=Vz21PRTLnk6NVDYnpP59KBks1d mUegzL//N0cmp9a7dEE3oTGIHLd4MiIXOSgeV0zikWtH+WVN9oGfLNtjQCRPFdegxql3eqA7x2Icd nxT3QoQ2dB7UNttJvvtZuUUH3gc5IJIeZEe8jo6+seK1o7Fpiu6AQ9c2yQ1rMv/5KIPty6v2u24eP 14k9fL1Ew1j3Fm2Mj8059Qclp0O57poO7nUl8ogsgrWOEv7nUiSxu/IH3EuNOcpZaVf2ADCpPLvuV FiZsBpsaMTRZBKV4DZIO3F0dVebdA5M8hLhbHs9GsH5nYe7QpWdiOP17QO88UTsPnbtkbT+vrI9+8 K3nogO6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyd4L-00EjKe-UJ; Wed, 30 Jun 2021 16:28:10 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyd4H-00EjK1-LF for linux-arm-kernel@lists.infradead.org; Wed, 30 Jun 2021 16:28:07 +0000 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 7F7E382C0B; Wed, 30 Jun 2021 18:28:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1625070481; bh=oHVEsrewW6stMNciWz3pWjRt7Jm6Y/3FuNvd0veTo1I=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=fzPuMJ6fVndf5oRktVYsHXMiVKB2tIG2p69L8YsBJdDgdYTCSCtlvmgeNP5uinFHP rezc0l1CU+jXZoaR+3CbPQaVj1wyTnLDoYLXmfam+Mudn7BaAqTQihSR5jBry9Owux mhBR+LSnjiXzG+CVUxgkV0vYCFt0vziUApcTTVOSC8SKrOeCGWt/pbYrtfEwYRET4H 3e4NXjojQKjaGay7olGPlYGb8r+t/DlY9qvqmkwpT8Iely3WX4TJbO1UnkgdwUl4Y0 YMhZWPyl9peQAKBp+q0pQnrXoqSFkouZRAUK+1pipgp0BGyDKN73VXYKVVvoFWBgJR rV88Sdf23pJUw== Subject: Re: [PATCH V8 0/4] soc: imx: add i.MX BLK-CTL support To: Frieder Schrempf , Adam Ford , "Peng Fan (OSS)" Cc: Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Philipp Zabel , Lucas Stach , Krzysztof Kozlowski , =?UTF-8?Q?Guido_G=c3=bcnther?= , Andrey Smirnov , devicetree , arm-soc , Linux Kernel Mailing List , Jacky Bai , Abel Vesa , Jagan Teki References: <20210629072941.7980-1-peng.fan@oss.nxp.com> From: Marek Vasut Message-ID: <181ac373-7701-361e-6364-6fc74b2d71fe@denx.de> Date: Wed, 30 Jun 2021 18:28:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210630_092806_098507_71BA4C42 X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/30/21 4:46 PM, Frieder Schrempf wrote: > On 30.06.21 14:09, Adam Ford wrote: >> On Wed, Jun 30, 2021 at 4:34 AM Peng Fan (OSS) wrote: >>> >>>> Subject: Re: [PATCH V8 0/4] soc: imx: add i.MX BLK-CTL support >>>> >>>> On Tue, Jun 29, 2021 at 1:56 AM Peng Fan (OSS) >>>> wrote: >>>>> >>>>> From: Peng Fan >>>>> >>>>> V8: >>>>> Revert one change in v7, force goto disable_clk for handshake when >>>>> power on in patch 3 One minor update to use if{} else {}, not if{}; >>>>> if{}; in patch 3 Typo Hankshake->Handshake >>>>> >>>> I am using ATF, branch lf_v2.4, from the NXP code aurora repo with U-Boot >>>> v2021.07-rc5 >>>> >>>> I applied this patch against linux-next, I applied the pgc patches [1], and the >>>> suggested power-domains to the otg1 and otg2 nodes. >>>> I am able to boot the device and use USB, but with this applied, I cannot wake >>>> from sleep. If I revert this, the system wakes from sleep again. >>> >>> I just tried linux-next without this patch on iMX8MM EVK, suspend/resume >>> not work. Per my last test, it works before. Not sure what changed in kernel. >>> >>> Which kernel are you using, any commit or git repo? I could try on imx8mm >>> evk and debug the issue you see. >> >> I used kernel-next, >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >> commit 889bab4c367a0ef58208fd80fafa74bb6e2dca26 (tag: next-20210621) >> >> I then applied the GPCv2 patch that Marek sent. You were CC'd on the >> e-mail from Marek, but I can forward the patch to you if you can't >> find it. >> I tested his patch and I was able to suspend-to-RAM and resume. >> Once I was comfortable that it worked, I then applied your patch >> series for the blk-ctl. >> With the blk-ctl series applied, the suspend-resume stopped working. > > Same here. I tested with linux-next-20210629 and as soon as I add the BLK-CTL driver and devicetree nodes, the resume after suspend causes a lockup each time. btw do you have etnaviv enabled ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel