From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A6CCC4332F for ; Thu, 22 Dec 2022 16:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hgw9Y3tuiVt3HccTCo0gIjmPwzYEnBdeZuB8EpxJY6g=; b=mwJ3gjW4u0BXkI a43Qo6tcIOWxkHd/CllcVb8mAZcv/4pPEcO1S5IcqIW2wC7KbhYpa3nD7SFeAbtB8XpJJRU3StOqA +1yYVHihK37zppKM+ox986fnBNqv/+i/hLRW2gtD2o1CXOxVp0X7hzV8LAkBqWcMDJt0BOAaTzpJp xr1fWym0Hc8FN0Ou4ej5JhqzksT3r50DtbjV/VGW62N4u/Hz6utPXZwg9nBzrn9DCXjVR+KGQa1EG 3KmEoAMjYB5gil513RHZc+YlVRirpZ6zQiUPWkH0lEIJUEDRRb2JW3sIchf+RVAG7AHc6tSRZBvV9 /KogjT0Ft4cdKwTi22/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8O4Z-00DqGN-4G; Thu, 22 Dec 2022 16:05:32 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8Nwr-00DlqA-OE for linux-arm-kernel@lists.infradead.org; Thu, 22 Dec 2022 15:57:36 +0000 Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BMBtNKr000553; Thu, 22 Dec 2022 16:57:16 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=mLYXc+UkL0/McAv2NjSFthugo2hDHA7ShsQrJDZkdzY=; b=PLCWdqKDQisgqSJ03zlXhazC8iRzwxddQMvUBmI9FXvnNdG1nWVnN7BLtK6EDluZ4Cdb juRG3sKI87ZBnWgh2cj7MlckRA6ti/0eNbvJ8KhgOvlHkeBYGGGeWb63DJXUsIc8tAS+ /sKqpwsObDg1J8okoppDHkpknt1j93V7vCnwWdug+kF7zJELbgUhBEClc49KcIrQtG+4 dAnEncMu/4+fa8DGql/va3xQ5Ye4xuLz4H4OlvaJajJNymsLXp7YQgAqmceuKQ18pSkB B/t+5aRVcDKouVfsJfCPuvYGB5rHHFeuG4eab6cIJx8slE8/9UmfLf/JHSkeEecF7z36 Zg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3mh42pxhse-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Dec 2022 16:57:16 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7A70310004D; Thu, 22 Dec 2022 16:57:11 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 14D67235F39; Thu, 22 Dec 2022 16:57:03 +0100 (CET) Received: from [10.201.21.217] (10.201.21.217) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.13; Thu, 22 Dec 2022 16:57:02 +0100 Message-ID: <18d0eca0-838e-92c3-4188-d8dcf480ef6e@foss.st.com> Date: Thu, 22 Dec 2022 16:57:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC PATCH 6/7] ARM: dts: stm32: add ETZPC as a system bus for STM32MP15x boards Content-Language: en-US To: Krzysztof Kozlowski , , , , , CC: , , , , , , References: <20221221173055.11719-1-gatien.chevallier@foss.st.com> <20221221173055.11719-7-gatien.chevallier@foss.st.com> <2e7c901c-e322-ded6-b170-6d2436d74c0f@kernel.org> <0bff5b2d-2837-57cb-5434-58158acc1483@foss.st.com> <041b77e0-40c5-e724-e5d9-f1da64d5e684@kernel.org> From: Gatien CHEVALLIER In-Reply-To: <041b77e0-40c5-e724-e5d9-f1da64d5e684@kernel.org> X-Originating-IP: [10.201.21.217] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-22_08,2022-12-22_03,2022-06-22_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221222_075734_342917_AC84300B X-CRM114-Status: GOOD ( 25.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/22/22 16:21, Krzysztof Kozlowski wrote: > On 22/12/2022 15:42, Gatien CHEVALLIER wrote: >> Hello, >> >> >> On 12/22/22 11:30, Krzysztof Kozlowski wrote: >>> On 21/12/2022 18:30, Gatien Chevallier wrote: >>>> The STM32 System Bus is an internal bus on which devices are connected. >>>> ETZPC is a peripheral overseeing the firewall bus that configures >>>> and control access to the peripherals connected on it. >>>> >>>> For more information on which peripheral is securable, please read >>>> the STM32MP15 reference manual. >>>> >>>> Signed-off-by: Gatien Chevallier >>>> --- >>>> arch/arm/boot/dts/stm32mp151.dtsi | 2737 +++++++++++++++-------------- >>>> 1 file changed, 1406 insertions(+), 1331 deletions(-) >>>> >>>> - lptimer1: timer@40009000 { >>>> + etzpc: etzpc@5c007000 { >>> >>> Node names should be generic. >>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation >> >> Will change to etzpc: bus@5c007000 in V3 >> >>> >>>> + compatible = "st,stm32mp15-sys-bus"; >>>> + reg = <0x5c007000 0x400>; >>>> #address-cells = <1>; >>>> - #size-cells = <0>; >>>> - compatible = "st,stm32-lptimer"; >>>> - reg = <0x40009000 0x400>; >>>> - interrupts-extended = <&exti 47 IRQ_TYPE_LEVEL_HIGH>; >>>> - clocks = <&rcc LPTIM1_K>; >>>> - clock-names = "mux"; >>>> - wakeup-source; >>>> - status = "disabled"; >>> >>> Why entire bus is disabled? What resources do you miss? >> >> Here, I did not want to modify the status of the nodes in the device > > By making it disabled you actually modify the status of any enabled > node. By making it enabled you do not cause any change. > >> tree. Nodes that are default enabled in the SoC device tree stay enabled >> and vice-versa. > > No, because parent is disabled. > >> IMO think this patch should not include these kind of >> changes in its scope. I describe the bus and the peripherals connected >> to it, nothing more :) > > I am not proposing to change existing nodes. I am asking why new node is > being disabled (because it is a new node, isn't it?). I'm sorry but the ETZPC node is not disabled. The patch is quite hard to read as I'm moving all securable/MCU isolation capable peripheral nodes under ETZPC. >>>> - #size-cells = <0>; >>>> - compatible = "st,stm32-lptimer"; >>>> - reg = <0x40009000 0x400>; >>>> - interrupts-extended = <&exti 47 IRQ_TYPE_LEVEL_HIGH>; >>>> - clocks = <&rcc LPTIM1_K>; >>>> - clock-names = "mux"; >>>> - wakeup-source; >>>> - status = "disabled"; are part of lptimer1 node, which is moved under ETZPC. ETZPC node is default enabled. Result after patch is: etzpc: etzpc@5c007000 { compatible = "st,stm32mp15-sys-bus"; reg = <0x5c007000 0x400>; #address-cells = <1>; #size-cells = <1>; feature-domain-controller; #feature-domain-cells = <2>; ranges; timers2: timer@40000000 { (...) Or do I misunderstand you comment? > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel