From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F11FBC2D0A3 for ; Mon, 9 Nov 2020 18:10:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7138320678 for ; Mon, 9 Nov 2020 18:10:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gXDFsZZy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="KUtZu1Rn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7138320678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8SrV+WSbrWAbummx9mSfZ0oWP1yk8i74a5BKFHPMbBk=; b=gXDFsZZyTEN3fO4xOnkt6HEqX gH6Wobge/ULZ5cntbLEcFXMN9CoZ/1QnRKvMkkrEac9Ymj3E/px7RFCSmea+118Oq1RmbrDiNQU33 IMefm3+jkUyXRo2uwxhNxCK+U5PvZNB7w1YLWYwgpHADcVSOJmoS2dYPb8/2zPJw7O5VclRSPl/0I jzD0d4Xz9RqzlwQgXGpNY012E5/vTIQ5gl5jAKd2jkKXJ5osvXOVuRta701TbyJ/N4RAqs0vxxhOZ FzlRNYetSrJWYG2lGn9lvbSB1/Pu9mKwFMdWWoCr46vYCDP6YULl0FqsCOUW1mn01LfUgsOhth2gv FfEtNyZJA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcBcK-0005fx-EA; Mon, 09 Nov 2020 18:10:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcBcH-0005fN-Ez for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 18:10:10 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E735F20678; Mon, 9 Nov 2020 18:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604945408; bh=nYCGURReaUreeGBHrXbl9iNHp3A/C4AwY6eb8qAExsQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KUtZu1RnUQqSxMBLI3fAWGVI5lMwBSpHUy5touvUvB0NURtA38bMOPugtz9BGhOQy vb35Fbvo9bPZjR3ZxgiiFfPdpk/Rha9GnYZk8knuTKFTryuOAjbfrxWFBSytOqzZZC sXJIhflIuW0amm+u+oHEvdGvGrD89NPunTQZb7cY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kcBcD-009BeV-RM; Mon, 09 Nov 2020 18:10:05 +0000 MIME-Version: 1.0 Date: Mon, 09 Nov 2020 18:10:05 +0000 From: Marc Zyngier To: Quentin Perret Subject: Re: [PATCH v1 17/24] kvm: arm64: Add __hyp_pa_symbol helper macro In-Reply-To: <20201109165933.GA447754@google.com> References: <20201109113233.9012-1-dbrazdil@google.com> <20201109113233.9012-18-dbrazdil@google.com> <20201109165933.GA447754@google.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <1951645a457232caeca323bec2af5408@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: qperret@google.com, dbrazdil@google.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, dennis@kernel.org, tj@kernel.org, cl@linux.com, mark.rutland@arm.com, lorenzo.pieralisi@arm.com, ascull@google.com, qwandor@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_131009_956163_00E97351 X-CRM114-Status: GOOD ( 15.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kernel-team@android.com, Lorenzo Pieralisi , Andrew Walbran , Suzuki K Poulose , Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Tejun Heo , Dennis Zhou , Christoph Lameter , David Brazdil , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry , Andrew Scull Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-11-09 16:59, Quentin Perret wrote: > Hey David, > > On Monday 09 Nov 2020 at 11:32:26 (+0000), David Brazdil wrote: >> Add helper macro for computing the PA of a kernel symbol in nVHE hyp >> code. This will be useful for computing the PA of a PSCI CPU_ON entry >> point. >> >> Signed-off-by: David Brazdil >> --- >> arch/arm64/kvm/hyp/nvhe/psci.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm64/kvm/hyp/nvhe/psci.c >> b/arch/arm64/kvm/hyp/nvhe/psci.c >> index b0b5df590ba5..7510b9e174e9 100644 >> --- a/arch/arm64/kvm/hyp/nvhe/psci.c >> +++ b/arch/arm64/kvm/hyp/nvhe/psci.c >> @@ -20,6 +20,16 @@ s64 hyp_physvirt_offset; >> >> #define __hyp_pa(x) ((phys_addr_t)((x)) + hyp_physvirt_offset) >> >> +#define __hyp_pa_symbol(sym) \ >> + ({ \ >> + extern char sym[]; \ >> + unsigned long kern_va; \ >> + \ >> + asm volatile("ldr %0, =%1" : "=r" (kern_va) \ >> + : "S" (sym)); \ >> + kern_va - kimage_voffset; \ >> + }) >> + > > Could this be simplified to __hyp_pa(hyp_symbol_addr(sym))? That would > avoid the dependency on kimage_voffset. I'm going to move away from evaluating kimage_voffset at runtime anyway, see [1]. Thanks, M. [1] https://lore.kernel.org/r/20201109175923.445945-1-maz@kernel.org -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel