From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 446A9C433FE for ; Mon, 10 Oct 2022 10:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=+8NyWu2HIA01oHaZo75KkyEd79y4GLkePKmCCl+lo5M=; b=piCjhKbuL0CaBg1swfOeXWUZvB E/x5bMCo7chdEr0cwh/vBvcCrDtx6vVnsUR9X1Cv9IroAxmA5TqyobFcvXEN+dKWNA+nJXutCidtO 6JeTYdqFyl6rs9tZDTvl+/XBWFRfs7s3onBS0Xjo4Xw3uGTjOEomoqwRiv7P9hSE+Q40AtjTQZ2BK jJ7Bb3MfZSaxfGxdsbIrGGhvy5xYUQHKZu1a/T0G6AMutQko5ddaKNfvH8wKC9uc5nroJD8h5v/Fi XWXPFa4UUowdLE7rF9PV4VocGnRF261CxRHcgbqa6zhWWy8ISpndS/ILxHdpapxC41pSw/NRr4Vcz u4Qvh1VA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohqUJ-000UV2-Eo; Mon, 10 Oct 2022 10:58:23 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohqUF-000UU8-IA for linux-arm-kernel@lists.infradead.org; Mon, 10 Oct 2022 10:58:21 +0000 Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MmG5h2ffzzpVsq; Mon, 10 Oct 2022 18:55:04 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 10 Oct 2022 18:58:13 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 10 Oct 2022 18:58:12 +0800 Subject: Re: [PATCH v2 1/2] ARM: Fix some check warnings of tool sparse To: Ard Biesheuvel CC: Russell King , , References: <20221010095346.1957-1-thunder.leizhen@huawei.com> <20221010095346.1957-2-thunder.leizhen@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <1ab4c651-f0ab-1107-1784-ad255dabc33a@huawei.com> Date: Mon, 10 Oct 2022 18:58:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221010_035819_977049_86754729 X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/10/10 18:20, Ard Biesheuvel wrote: > On Mon, 10 Oct 2022 at 11:56, Zhen Lei wrote: >> >> Fix the following warnings: >> warning: incorrect type in initializer (different address spaces) >> expected unsigned short [noderef] __user *register __p >> got unsigned short [usertype] * >> warning: cast removes address space '__user' of expression >> >> Signed-off-by: Zhen Lei >> --- >> arch/arm/kernel/traps.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c >> index 20b2db6dcd1ced7..34aa80c09c508c1 100644 >> --- a/arch/arm/kernel/traps.c >> +++ b/arch/arm/kernel/traps.c >> @@ -188,9 +188,9 @@ static void dump_instr(const char *lvl, struct pt_regs *regs) >> } >> } else { >> if (thumb) >> - bad = get_user(val, &((u16 *)addr)[i]); >> + bad = get_user(val, &((u16 __user *)addr)[i]); >> else >> - bad = get_user(val, &((u32 *)addr)[i]); >> + bad = get_user(val, &((u32 __user *)addr)[i]); >> } >> >> if (!bad) >> @@ -455,15 +455,15 @@ asmlinkage void do_undefinstr(struct pt_regs *regs) >> if (processor_mode(regs) == SVC_MODE) { >> #ifdef CONFIG_THUMB2_KERNEL >> if (thumb_mode(regs)) { >> - instr = __mem_to_opcode_thumb16(((u16 *)pc)[0]); >> + instr = __mem_to_opcode_thumb16(((__force u16 *)pc)[0]); > > Shouldn't this be __user as well? (and below) unsigned int instr; void __user *pc; The __user can clear the warning, but a new warning will be generated. instr = __mem_to_opcode_thumb16(((u16 *)pc)[0]); ^new ^old arch/arm/kernel/traps.c:473:33: warning: dereference of noderef expression > >> if (is_wide_instruction(instr)) { >> u16 inst2; >> - inst2 = __mem_to_opcode_thumb16(((u16 *)pc)[1]); >> + inst2 = __mem_to_opcode_thumb16(((__force u16 *)pc)[1]); >> instr = __opcode_thumb32_compose(instr, inst2); >> } >> } else >> #endif >> - instr = __mem_to_opcode_arm(*(u32 *) pc); >> + instr = __mem_to_opcode_arm(*(__force u32 *) pc); >> } else if (thumb_mode(regs)) { >> if (get_user(instr, (u16 __user *)pc)) >> goto die_sig; >> -- >> 2.25.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > . > -- Regards, Zhen Lei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel