From: Scott Branden <scott.branden@broadcom.com>
To: Stefan Wahren <wahrenst@gmx.net>,
Wolfram Sang <wsa@the-dreams.de>, Eric Anholt <eric@anholt.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] i2c: bcm2835: Add full name of devicetree node to adapter name
Date: Tue, 27 Aug 2019 14:10:46 -0700 [thread overview]
Message-ID: <1c42daa2-f7f7-baac-2d44-f9d86848d331@broadcom.com> (raw)
In-Reply-To: <1566925456-5928-4-git-send-email-wahrenst@gmx.net>
On 2019-08-27 10:04 a.m., Stefan Wahren wrote:
> Inspired by Lori Hikichi's patch for iproc, this adds the full name of
> the devicetree node to the adapter name. With the introduction of
> BCM2711 it's very difficult to distinguish between the multiple instances.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> =2D--
> drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm=
> 2835.c
> index ab5502f..e01b2b5 100644
> =2D-- a/drivers/i2c/busses/i2c-bcm2835.c
> +++ b/drivers/i2c/busses/i2c-bcm2835.c
> @@ -472,7 +472,8 @@ static int bcm2835_i2c_probe(struct platform_device *p=
> dev)
> i2c_set_adapdata(adap, i2c_dev);
> adap->owner =3D THIS_MODULE;
> adap->class =3D I2C_CLASS_DEPRECATED;
> - strlcpy(adap->name, "bcm2835 I2C adapter", sizeof(adap->name));
> + snprintf(adap->name, sizeof(adap->name), "bcm2835 (%s)",
> + of_node_full_name(pdev->dev.of_node));
> adap->algo =3D &bcm2835_i2c_algo;
> adap->dev.parent =3D &pdev->dev;
> adap->dev.of_node =3D pdev->dev.of_node;
> =2D-
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-27 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 17:04 [PATCH 0/3] i2c: bcm2835: Add bcm2711 support Stefan Wahren
2019-08-27 17:04 ` [PATCH 1/3] dt-bindings: i2c: bcm2835: Add brcm,bcm2711 compatible Stefan Wahren
2019-08-29 18:52 ` Wolfram Sang
2019-08-27 17:04 ` [PATCH 2/3] i2c: bcm2835: Avoid clk stretch quirk for BCM2711 Stefan Wahren
2019-08-29 18:52 ` Wolfram Sang
2019-09-12 17:21 ` Matthias Brugger
2019-08-27 17:04 ` [PATCH 3/3] i2c: bcm2835: Add full name of devicetree node to adapter name Stefan Wahren
2019-08-27 21:10 ` Scott Branden [this message]
2019-08-29 18:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c42daa2-f7f7-baac-2d44-f9d86848d331@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).