From: Florian Fainelli <f.fainelli@gmail.com>
To: Stefan Wahren <wahrenst@gmx.net>, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Eric Anholt <eric@anholt.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Markus Mayer <mmayer@broadcom.com>
Cc: devicetree@vger.kernel.org, Chen-Yu Tsai <wens@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 0/4] ARM: Enable thermal support for Raspberry Pi 4
Date: Sat, 2 Nov 2019 13:08:15 -0700 [thread overview]
Message-ID: <1c8ccf12-743c-cad0-bd63-3f46abe7d1c4@gmail.com> (raw)
In-Reply-To: <1572615749-9524-1-git-send-email-wahrenst@gmx.net>
On 11/1/2019 6:42 AM, Stefan Wahren wrote:
> This series enables thermal support for the Raspberry Pi 4. Neither the
> bcm2835_thermal nor the brcmstb_thermal are suitable for the BCM2711.
> So add a new thermal driver to read out the SoC temperature from the
> AVS RO block of the BCM2711.
It seems to me that with minor tweaks you could use the brcmstb_thermal
driver, since the two key differences are essentially:
- lack of interrupt, which is also the case on the latest STB SoCs
- different way to determine that data is valid, by checking both bit 16
and bit 10, as opposed to bit 11, and a reduced ADC code from 11 bits
down to 10.
This seems like a simple enough set of changes to build on top of this
patch series:
https://lore.kernel.org/linux-arm-kernel/20191030182132.25763-1-f.fainelli@gmail.com/
My concern is that we went down that road before with other drivers like
bcm2835-rng and bcm63xx-rng, when really there were little to no
differences other than some integrations bits (different clock,
compatible, and more important people having worked separately on those
things).
Your call, the patch series looks good to me otherwise:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-02 20:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 13:42 [PATCH 0/4] ARM: Enable thermal support for Raspberry Pi 4 Stefan Wahren
2019-11-01 13:42 ` [PATCH 1/4] dt-bindings: Add BCM2711 thermal Stefan Wahren
2019-11-06 4:21 ` Rob Herring
2019-11-06 4:41 ` Florian Fainelli
2019-11-07 19:26 ` Stefan Wahren
2019-11-01 13:42 ` [PATCH 2/4] thermal: Add BCM2711 thermal driver Stefan Wahren
2019-11-01 13:42 ` [PATCH 3/4] ARM: dts: bcm2711: Enable thermal Stefan Wahren
2019-11-01 13:42 ` [PATCH 4/4] ARM: configs: Build BCM2711 thermal as module Stefan Wahren
2019-11-02 20:08 ` Florian Fainelli [this message]
2019-11-03 8:43 ` [PATCH 0/4] ARM: Enable thermal support for Raspberry Pi 4 Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c8ccf12-743c-cad0-bd63-3f46abe7d1c4@gmail.com \
--to=f.fainelli@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mmayer@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=wahrenst@gmx.net \
--cc=wens@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).