From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1868BC4338F for ; Thu, 29 Jul 2021 19:20:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D103A60462 for ; Thu, 29 Jul 2021 19:20:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D103A60462 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9epSwJmh1HxGJE5gnNW7gE2BS8tpYbaZ2WgwQnTrFQ8=; b=zgPvofjScVi/MvxcJw97PXUpIt KnRZ8MttbBA0IjyDjmOs4oz1UzntkWJ7sGrOjbimesiYiwf6/CBv1OlX+CxF74GSs44FT3rS/Xnwd bLYy6j20kZxF3f5/aOoQOSa6XuQgRjVY/ZG7sVk8KvaqBPlMCEsq61//KsdQJe0nKFFQAgdKR2Qlm GRyOUzaMYhzEvlG2NaUedTHCDhg63n31c6NtIWn2i4BKrGsiU1gQWMyecY0Y+LJZ96b1bxF736D8+ dhY/n/5xELAtS3yD/gYiBrn6Mls74wZH8a/SJlY7JpZN91/7pzN2sHps/K3G/y7qKQe6UI1gCanUl QIKXH5pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9BYH-005dt2-7y; Thu, 29 Jul 2021 19:18:41 +0000 Received: from smtp-out2.suse.de ([195.135.220.29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9BYD-005dsA-L8 for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 19:18:39 +0000 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DE36B1FD6C; Thu, 29 Jul 2021 19:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627586311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ARi7fzuP6PspqOeeSxIq7f++s/zF6k625nFKZfwFtBY=; b=KsG6VOhcgqdVeyqYhniNovQGNCc1rM1BVsnW7Tu3idQfSVON7/FrE7sBEhzvCfDf5fPPou r8p2JRdLAGbxUw6iboJ0UMMTNFpnqkV584up9x5KvJrd4nOkn3ZJ5bGxO0DVSI/c7CtBdV kM73nyRjX+p30DK+2gYtiSeONxj9sHw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627586311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ARi7fzuP6PspqOeeSxIq7f++s/zF6k625nFKZfwFtBY=; b=PnOg9mOoda2BHjNEHphWHZ3PsVj5irQTGyAoXXZ+3hb2iy0d7cMsljAzjdkoG2nRRe8TQT UHhhtCs/na9gD1AQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 159FC13756; Thu, 29 Jul 2021 19:18:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id umyQAwf/AmFiaAAAGKfGzw (envelope-from ); Thu, 29 Jul 2021 19:18:31 +0000 Subject: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces To: Sam Ravnborg , Dan.Sneddon@microchip.com References: <20210727182721.17981-4-tzimmermann@suse.de> <3d2f6b84-dd07-d925-a8b8-2bfd5fc736d9@microchip.com> <2f04b986-6b41-62f9-1587-23818b841655@suse.de> <793514f6-0270-771b-fe36-f82edf4e5fd2@microchip.com> From: Thomas Zimmermann Message-ID: <1df22406-2e91-c15a-49dc-1cf33522a142@suse.de> Date: Thu, 29 Jul 2021 21:18:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_121837_898259_93CC8097 X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, liviu.dudau@arm.com, stefan@agner.ch, amd-gfx@lists.freedesktop.org, anitha.chrisanthus@intel.com, patrik.r.jakobsson@gmail.com, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, daniel@ffwll.ch, edmund.j.dea@intel.com, s.hauer@pengutronix.de, alison.wang@nxp.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, dri-devel@lists.freedesktop.org, sean@poorly.run, linux-arm-kernel@lists.infradead.org, tomba@kernel.org, bbrezillon@kernel.org, jyri.sarha@iki.fi, christian.koenig@amd.com, robdclark@gmail.com, kernel@pengutronix.de, alexander.deucher@amd.com, shawnguo@kernel.org, brian.starkey@arm.com Content-Type: multipart/mixed; boundary="===============2134770924103279913==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2134770924103279913== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7KdZdn9qKKUSuKkMys46FDSsbCZWJFWg8" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7KdZdn9qKKUSuKkMys46FDSsbCZWJFWg8 Content-Type: multipart/mixed; boundary="k8RKRzHP1SDzHIj8TPo5gmhRo3stMnzU2"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , Dan.Sneddon@microchip.com Cc: daniel@ffwll.ch, airlied@linux.ie, alexander.deucher@amd.com, christian.koenig@amd.com, liviu.dudau@arm.com, brian.starkey@arm.com, bbrezillon@kernel.org, Nicolas.Ferre@microchip.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, stefan@agner.ch, alison.wang@nxp.com, patrik.r.jakobsson@gmail.com, anitha.chrisanthus@intel.com, robdclark@gmail.com, edmund.j.dea@intel.com, sean@poorly.run, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, jyri.sarha@iki.fi, tomba@kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Message-ID: <1df22406-2e91-c15a-49dc-1cf33522a142@suse.de> Subject: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces References: <20210727182721.17981-4-tzimmermann@suse.de> <3d2f6b84-dd07-d925-a8b8-2bfd5fc736d9@microchip.com> <2f04b986-6b41-62f9-1587-23818b841655@suse.de> <793514f6-0270-771b-fe36-f82edf4e5fd2@microchip.com> In-Reply-To: --k8RKRzHP1SDzHIj8TPo5gmhRo3stMnzU2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 28.07.21 um 22:11 schrieb Sam Ravnborg: > Hi Dan, >=20 >>> >>> I think I got it - we need to set irq_enabled to true. >>> The documentation says so: >>> " >>> * @irq_enabled: >>> * >>> * Indicates that interrupt handling is enabled, specifical= ly vblank >>> * handling. Drivers which don't use drm_irq_install() need= to set this >>> * to true manually. >>> " >>> >>> Can you try to add the following line: >>> >>> >>> +static int atmel_hlcdc_dc_irq_install(struct drm_device *dev, unsign= ed int irq) >>> +{ >>> + int ret; >>> + >>> + if (irq =3D=3D IRQ_NOTCONNECTED) >>> + return -ENOTCONN; >>> + >>> >>> dev->irq_enabled =3D true; <=3D THIS LINE >>> >>> >>> + atmel_hlcdc_dc_irq_disable(dev); >>> + >>> + ret =3D request_irq(irq, atmel_hlcdc_dc_irq_handler, 0, dev->= driver->name, dev); >>> + if (ret) >>> + return ret; >>> >>> I hope this fixes it. >> >> It does! With the irq_enabled line added everything is looking good. Are you sure, you're testing with the latest drm-misc-next or drm-tip?=20 Because using irq_enabled is deprecated and the flag was recently=20 replaced by commit 1e4cd78ed493 ("drm: Don't test for IRQ support in=20 VBLANK ioctls"). Best regards Thomas >=20 > Great, thanks for testing. >=20 > Thomas - I assume you will do a re-spin and there is likely some fixes > for the applied IRQ conversions too. >=20 > Note - irq_enabled must be cleared if request_irq fails. I did not > include this in the testing here. >=20 > Sam >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --k8RKRzHP1SDzHIj8TPo5gmhRo3stMnzU2-- --7KdZdn9qKKUSuKkMys46FDSsbCZWJFWg8 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmEC/wYFAwAAAAAACgkQlh/E3EQov+B2 7Q//UVCwvB5dM0KBGIxYZP4EX3WE120wH55oAGYqSC297HYUYtiK0ao/Tnl3VjwrBTpVtys/tufE Ytjsrbt3HqISjsU+ii3u87Ep/0p6Fd6RfqjH8JzzRSt8COjfNPdAGmlyugZvS0fwfywgZw/4FCP6 dg0Jhzft+YzF3XsF8I3/2C+xOGlV/85T2OY+WHNLjXfrD8Q4YaK+0Kd05P/HIIJscHeR/ttRsmdB WyxCwb1wiYYfNb2lfet/slXQo5LqSSVZwsO06DDFxg6PvrhMls7mB+q8jZnsMJ3llI7NQm9UXkn/ Qy2fGTBQIcgI7n2avq7cBEwdRMupuqCli43/tk+TLGJuiKoa/dT8e88E+ktm6zCIDq9/qv0I1JyU o7ccJI6aVI8fgQROHEPkBXqnZgDFAPJMnejjErb7mLvfCdrPb1E0yTH1yHlu3hAqA+BTWUsxD+HQ AYWEK07ne2rn7x5rzJivWXvZBaFzf3RqU5SO0h+pjLW0Reez3l8AlvXwt/rjdug0TtEpNv0J9XyV 1hnCNvBn24cQ2TrL0ETZ9GNljADsV416eECymXsLG2/A8sescEJ6LVjjXTaMo12G/1rlduaBSF5U JWMQR7qWFMRmfU/xaN+ccZXxe+JwWAfsnhRWmuDYgUWyQXparjHKTUshRg+BmBvB+Sl9CIFhDYln Duw= =lqN7 -----END PGP SIGNATURE----- --7KdZdn9qKKUSuKkMys46FDSsbCZWJFWg8-- --===============2134770924103279913== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2134770924103279913==--