From: Matthias Brugger <matthias.bgg@gmail.com>
To: Gene Chen <gene.chen.richtek@gmail.com>,
jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org
Cc: gene_chen@richtek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cy_huang@richtek.com,
benjamin.chao@mediatek.com, linux-mediatek@lists.infradead.org,
dmurphy@ti.com, linux-leds@vger.kernel.org,
Wilma.Wu@mediatek.com, linux-arm-kernel@lists.infradead.org,
shufan_lee@richtek.com
Subject: Re: [PATCH v13 5/5] leds: mt6360: Add LED driver for MT6360
Date: Tue, 12 Jan 2021 13:37:11 +0100 [thread overview]
Message-ID: <1e752ae6-f973-11c3-1780-d11d2af497be@gmail.com> (raw)
In-Reply-To: <1608547554-6602-6-git-send-email-gene.chen.richtek@gmail.com>
On 21/12/2020 11:45, Gene Chen wrote:
> From: Gene Chen <gene_chen@richtek.com>
[...]
> +
> +static const struct of_device_id __maybe_unused mt6360_led_of_id[] = {
> + { .compatible = "mediatek,mt6360-led", },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, mt6360_led_of_id);
> +
I think we should fix MFD code to not need to use a DT binding here. See [1].
Regards,
Matthias
[1] https://lore.kernel.org/linux-mediatek/20210111164118.GE4728@sirena.org.uk/
> +static struct platform_driver mt6360_led_driver = {
> + .driver = {
> + .name = "mt6360-led",
> + .of_match_table = mt6360_led_of_id,
> + },
> + .probe = mt6360_led_probe,
> + .remove = mt6360_led_remove,
> +};
> +module_platform_driver(mt6360_led_driver);
> +
> +MODULE_AUTHOR("Gene Chen <gene_chen@richtek.com>");
> +MODULE_DESCRIPTION("MT6360 LED Driver");
> +MODULE_LICENSE("GPL v2");
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-12 12:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 10:45 [PATCH v13 0/5] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-12-21 10:45 ` [PATCH v13 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH Gene Chen
2020-12-21 10:45 ` [PATCH v13 2/5] leds: flash: Fix multicolor no-ops registration by return 0 Gene Chen
2021-02-19 10:54 ` Pavel Machek
2020-12-21 10:45 ` [PATCH v13 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions Gene Chen
2021-02-19 10:47 ` Pavel Machek
2021-03-02 6:08 ` Gene Chen
2021-03-22 10:54 ` Gene Chen
2020-12-21 10:45 ` [PATCH v13 4/5] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-12-21 10:45 ` [PATCH v13 5/5] leds: mt6360: Add LED driver for MT6360 Gene Chen
2021-01-12 12:37 ` Matthias Brugger [this message]
2021-02-19 10:53 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e752ae6-f973-11c3-1780-d11d2af497be@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).