From: Marek Vasut <marex@denx.de>
To: Nicolas Toromanoff <nicolas.toromanoff@foss.st.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: linux-crypto@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] crypto: stm32/cryp - fix race condition
Date: Fri, 29 Oct 2021 16:23:51 +0200 [thread overview]
Message-ID: <1ec60d9c-1ab4-8a92-1c6d-8093232ca039@denx.de> (raw)
In-Reply-To: <20211029135454.4383-5-nicolas.toromanoff@foss.st.com>
On 10/29/21 3:54 PM, Nicolas Toromanoff wrote:
> Erase key before finalizing request.
> Fixes: 9e054ec21ef8 ("crypto: stm32 - Support for STM32 CRYP crypto module")
Can you be a bit more specific in your commit messages ? That applies to
the entire patchset. It is absolutely impossible to tell what race is
fixed here or why it is fixed by exactly this change. This applies to
the entire series.
And while I am at it, does the CRYP finally pass at least the most basic
kernel boot time crypto tests or does running those still overwrite
kernel memory and/or completely crash or lock up the machine ?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-29 14:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 13:54 [PATCH 0/8] STM32 CRYP driver: many fixes Nicolas Toromanoff
2021-10-29 13:54 ` [PATCH 1/8] crypto: stm32/cryp - defer probe for reset controller Nicolas Toromanoff
2021-10-29 13:54 ` [PATCH 2/8] crypto: stm32/cryp - don't print error on probe deferral Nicolas Toromanoff
2021-10-29 13:54 ` [PATCH 3/8] crypto: stm32/cryp - fix CTR counter carry Nicolas Toromanoff
2021-10-31 12:28 ` Ard Biesheuvel
2021-11-02 11:12 ` Nicolas Toromanoff
2021-10-29 13:54 ` [PATCH 4/8] crypto: stm32/cryp - fix race condition Nicolas Toromanoff
2021-10-29 14:23 ` Marek Vasut [this message]
2021-10-29 15:21 ` Nicolas Toromanoff
2021-10-29 16:48 ` Marek Vasut
2021-10-29 13:54 ` [PATCH 5/8] crypto: stm32/cryp - check early input data Nicolas Toromanoff
2021-10-29 13:54 ` [PATCH 6/8] crypto: stm32/cryp - fix double pm exit Nicolas Toromanoff
2021-10-29 13:54 ` [PATCH 7/8] crypto: stm32/cryp - fix bugs and crash in tests Nicolas Toromanoff
2021-10-29 13:54 ` [PATCH 8/8] crypto: stm32/cryp - reorder hw initialization Nicolas Toromanoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ec60d9c-1ab4-8a92-1c6d-8093232ca039@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.toromanoff@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).