From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF476C56202 for ; Thu, 26 Nov 2020 12:57:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F71421D46 for ; Thu, 26 Nov 2020 12:57:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TFnnwJ0a"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="HqpYXplK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F71421D46 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0D4A/hypFE5aSu8a8rtlYDUw7hayJWDO3fzEWVnRAEM=; b=TFnnwJ0aufQBYQRwZccV1zwua FwnQPflS9C2lZIkAj+Lo0lMbXhi6l90Zr+EmugViHOjJkM5suqnVRzeEl6/jB8+COrvH08bqJOVur FyT6COX3uDo9QDDu3GlhKD7IOFwYucqOxZIwi1cjsT3tBeNvp3V0PJ4U9QB//D2Zg1rTr8qGFk8+U RrbvouOwphfFtcaf3txNLV4QXr6p4yWN5DCziaDdXjAe8lnEkTcpuoDggwh/yv6+TCcAh9a0z7tRP vR81C1k8KSv1NkqnEzKZdyBa6fLY5pZJcCPcIOj2hUgo/6nXltbxVQsO4kXxrft9iMqOmkVmXWH1G P7CfHBJjQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiGoq-0006TG-Gq; Thu, 26 Nov 2020 12:56:16 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiGmE-0005mk-Ib for linux-arm-kernel@lists.infradead.org; Thu, 26 Nov 2020 12:53:36 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0AQCrKGM023622; Thu, 26 Nov 2020 06:53:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1606395200; bh=8/i0PLwLC3PRuf2Girkk7ibqMIDhWokbjMZAt9wBkBQ=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=HqpYXplKRSKhcYglOcByMX66sSMECwWSazz3TavTY8gVsDOzIO7NLcucUzMomuFA1 pg8IN7CUEqvbN7LnN5lGcFiXSNy8X0aHbrSRCHG2E9hplmoRk6+yRLcSAZ+iEIfpLO 3ZT1Wg+8+zVx6cMjTqw1UCv61J34/c0bee8KYxrU= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0AQCrK0e011046 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 26 Nov 2020 06:53:20 -0600 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 26 Nov 2020 06:53:20 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 26 Nov 2020 06:53:20 -0600 Received: from [10.250.235.36] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0AQCrG9p031373; Thu, 26 Nov 2020 06:53:16 -0600 Subject: Re: [PATCH 1/3] dt-bindings: pci: ti, j721e: Fix "ti, syscon-pcie-ctrl" to take argument From: Kishon Vijay Abraham I To: Rob Herring , Lorenzo Pieralisi References: <20201116173141.31873-1-kishon@ti.com> <20201116173141.31873-2-kishon@ti.com> <20201118211139.GA1815279@bogus> <1e9b0b56-a42d-bea0-704b-6209532b1abe@ti.com> Message-ID: <1ed82ab5-6171-108d-9b92-a18389044174@ti.com> Date: Thu, 26 Nov 2020 18:23:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1e9b0b56-a42d-bea0-704b-6209532b1abe@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201126_075334_876142_661292A4 X-CRM114-Status: GOOD ( 21.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Tero Kristo , Tom Joseph , Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On 20/11/20 10:39 am, Kishon Vijay Abraham I wrote: > Hi Rob, > > On 19/11/20 2:41 am, Rob Herring wrote: >> On Mon, Nov 16, 2020 at 11:01:39PM +0530, Kishon Vijay Abraham I wrote: >>> Fix binding documentation of "ti,syscon-pcie-ctrl" to take phandle with >>> argument. The argument is the register offset within "syscon" used to >>> configure PCIe controller. >>> >>> Link: Link: http://lore.kernel.org/r/CAL_JsqKiUcO76bo1GoepWM1TusJWoty_BRy2hFSgtEVMqtrvvQ@mail.gmail.com >> >> Link: Link: ? >> >> AIUI, 'Link' is supposed to be a link to this patch. I guess more than 1 >> Link would be okay though. > > Two Links was a typo, will fix it in the next revision. Nishanth as well > was asking about using "Link:" tag for a mailing list discussion. > > I started using it after Lorenzo had asked me to use Link tag for > mailing list discussion here sometime back. > > https://patchwork.kernel.org/project/linux-pci/patch/20171219083627.7904-1-kishon@ti.com/#21350261 > >> >>> Signed-off-by: Kishon Vijay Abraham I >>> --- >>> .../devicetree/bindings/pci/ti,j721e-pci-ep.yaml | 12 ++++++++---- >>> .../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 12 ++++++++---- >>> 2 files changed, 16 insertions(+), 8 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml >>> index 3ae3e1a2d4b0..e9685c0bdc3e 100644 >>> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml >>> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml >>> @@ -29,9 +29,13 @@ properties: >>> - const: mem >>> >>> ti,syscon-pcie-ctrl: >>> - description: Phandle to the SYSCON entry required for configuring PCIe mode >>> - and link speed. >>> - $ref: /schemas/types.yaml#/definitions/phandle >>> + allOf: >> >> You no longer need allOf here. > > hmm, don't we need it for specifying phandle with fixed cells? FWIW, I > was referring > > https://github.com/devicetree-org/dt-schema/blob/master/test/schemas/good-example.yaml#L187 Can you clarify this please? Thank You, Kishon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel