From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7B5C4708F for ; Tue, 1 Jun 2021 08:47:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 580CE61370 for ; Tue, 1 Jun 2021 08:47:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 580CE61370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:Cc:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BX13kBQRUbeiK8vcFo4y6btmzIytrQo8w8JHo/pUa0w=; b=i6AIuofqHp/9lwCS+2qWF9CkK1 cvZ4M0kt68rUj4IIoi/dmJ3n6Vk0YBJEvcx41zmtZ2VuqTDK2MGV+ErG3ikuwwOJaVv27YE9jieoM lHub2Vqm0YeRQlGlme9o6dzlIV6W1pbe50TjxsZk29iItg/xABul3x6ad6CyBa1gE5qtDVMQCcgkJ 8+NwgNLZFWiniDc43VRzZ/wFr0akk8cyVIZEe/lONEimOuz6lsGcv7I+YqJt5P9Vlq7vOrC6w+obM Z8mkMmQirDTzSVE41IIgx+Ef2gh1oyPgIxuYo3d/snkSAp6f34+GLsJ8dSWW9uXTN4NwWPlkDQfHA wGd725Qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo01v-00FOyE-Pn; Tue, 01 Jun 2021 08:45:44 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo01s-00FOw9-9Q for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 08:45:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622537139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ei1+7YPTwhcGwSC6x5usnbU/cNlmjtRYkQNi6UDFTrc=; b=JMtWMkqOud89CFV1m9y15fGRCZZH0lMn1YovydtanVlNpVbWVJKTZoXE+R6lTqDVyWJyRI PEfjltyZo1K0T9xTGD4AwqJbDg0fx0SklY5UDStw5qSBvsh5D7W1Gc8y9focEPpGeuTjzH se8z7DkyzwCggGrz2+TMW5yCSa+Uee4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-SWVkxV3XMpi0f8Y0Gq7xsg-1; Tue, 01 Jun 2021 04:45:37 -0400 X-MC-Unique: SWVkxV3XMpi0f8Y0Gq7xsg-1 Received: by mail-wm1-f71.google.com with SMTP id 19-20020a05600c2313b0290193637766d9so847569wmo.7 for ; Tue, 01 Jun 2021 01:45:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Ei1+7YPTwhcGwSC6x5usnbU/cNlmjtRYkQNi6UDFTrc=; b=GmZc1HZSYJWA4kHOj2uAMXuSfopD/1kfUQYeD3WhZ+xU4ykZXMrN6p1f4Qmp4aX3ZS ke4LhQ3rzMwl2TK9WUnmM+8/at7ZP1A7xV4HouBdVo+r4/xvq0fFAoIFgWQjTpHJVFWI qGDOja8kYiVlDgQKoeWr5jVNwbR1VAz1ZTW3IU5e5lvsljdCgty1xhBw7xs9ZuF9Cqdk Msjh4upYdBmkUzIg1I0nVNpOuuYv0Iox66s4JeSgSijAyEsBW5H60n7VPFdCdPOd/+PN kxnJLhBI+hamQ2xxSiEXDPS9igt0KaSMviM3dbvXYZciuyo4Cf2cB12mlR3fXF+gd1hq MZvA== X-Gm-Message-State: AOAM530hiDdYLzreJMrSQkeAncwDcLDZJA/GJiVsKbcvwl4PEda3s28x 89HU4IfQ+IkkXsnyRJkzLXbSn4EZlVszDkUXur+c5MWgqD1GGNQvLCvAZzvon6cUlazfI1NDiL1 HoEPqfbdbLjsCFJf+ZWlGVuTd4CCOCFirB10= X-Received: by 2002:a05:600c:2256:: with SMTP id a22mr3376720wmm.138.1622537136544; Tue, 01 Jun 2021 01:45:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw71orUED6J0M5xRL2FPbrXf1zLtQk15md+bXCGp928W5f5vqEbcF2SNwRqRon22LUBP3L6NQ== X-Received: by 2002:a05:600c:2256:: with SMTP id a22mr3376705wmm.138.1622537136338; Tue, 01 Jun 2021 01:45:36 -0700 (PDT) Received: from [192.168.3.132] (p5b0c69ce.dip0.t-ipconnect.de. [91.12.105.206]) by smtp.gmail.com with ESMTPSA id e26sm16961562wmh.39.2021.06.01.01.45.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 01:45:36 -0700 (PDT) To: Mike Rapoport , linux-kernel@vger.kernel.org Cc: Andrew Morton , Catalin Marinas , Christian Borntraeger , Heiko Carstens , Mike Rapoport , Russell King , Thomas Bogendoerfer , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org References: <20210531122959.23499-1-rppt@kernel.org> <20210531122959.23499-2-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Subject: Re: [RFC/RFT PATCH 1/5] s390: make crashk_res resource a child of "System RAM" Message-ID: <1efc386c-2cb4-164f-7194-497f142f969f@redhat.com> Date: Tue, 1 Jun 2021 10:45:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210531122959.23499-2-rppt@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_014540_432284_2064EAD3 X-CRM114-Status: GOOD ( 14.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31.05.21 14:29, Mike Rapoport wrote: > From: Mike Rapoport > > Commit 4e042af463f8 ("s390/kexec: fix crash on resize of reserved memory") > added a comment that says "crash kernel resource should not be part of the > System RAM resource" but never explained why. As it looks from the code in > the kernel and in kexec there is no actual reason for that. Are you sure? Looking at kexec-tools: kexec/arch/s390/kexec-s390.c get_memory_ranges_s390() wants "System RAM" and Crash kernel only with "with_crashk=1". Your patch would change that. "Crash kernel" would always be included if you make it a child of "System RAM". Further, get_memory_ranges() and is_crashkernel_mem_reserved() look out for "Crash kernel\n" via parse_iomem_single(). However, parse_iomem_single() does not care about ranges that start with spaces IIRC via sscanf(line, "%llx-%llx : %n" ... So once you make "Crash kernel" a child of "System RAM", kexec-tools would break if I'm not completely wrong. -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel