From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEEBC43381 for ; Mon, 11 Mar 2019 12:08:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BD28206BA for ; Mon, 11 Mar 2019 12:08:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qfVwWtI3"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=lucaceresoli.net header.i=@lucaceresoli.net header.b="aisdqNz0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BD28206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lucaceresoli.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=QckRgYoJ1t/bXo9oxASrZf8sm+TJZPtGO1GM58RUUXw=; b=qfVwWtI3usGxK+fikR/cWon+++ CgcyT9RtOgMKMAcKYCZ5TJS8X7c4WuG/Ql5xJO96iXyMqiF9Z+Tzh3mSP610U1KLg79+Avh3eFcC6 INwOvFQibcdKeDZrbl93OKh47M/jiZrCAPLmMXEtYVyyhYlXbI228K3rAviWSrY+uncMVTiqqMAxq TfckPdbVhPU+bNCFf3pwooPruNNN71zq3sPt0JdXVnFYHHHtjgKgGIuJLd3QUSRp3ZF0L1NZHRPq0 ue9zSBOYDj3Dh152bINh7rP2weD1Tn/1SNqzCt092IYGVg7Gu6u/ehQZEVAQXxyr6TULmQUrEnYBQ X0CPJRpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Jj9-000684-4c; Mon, 11 Mar 2019 12:08:19 +0000 Received: from hostingweb31-40.netsons.net ([89.40.174.40]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Jj5-00067I-Vm for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2019 12:08:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lucaceresoli.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/NoQ0wwIA2IHYfQP4VF8zClSWplCmHXSuxQDutBvUqs=; b=aisdqNz0czfqwEx5egi7B6xNqS 3JdKlmu7/wIfyvDS4KfO+fy4gmP8xvyE6ShfiWD5kWVT7pv3MiWSBXzuqXFGtHy/yuD9EB4H6rl3S d/lFaFVHfl3vuJakanpABbpnpnKlULQKdzYMzfkhD3c0ndwZzbqXF260bhnPL4zjpuO8=; Received: from [109.168.11.45] (port=50852 helo=[192.168.101.76]) by hostingweb31.netsons.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1h3Jiw-003lft-NX; Mon, 11 Mar 2019 13:08:06 +0100 Subject: Re: [PATCH v3 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem To: Vishal Sagar , Vishal Sagar , Hyun Kwon , "laurent.pinchart@ideasonboard.com" , "mchehab@kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , Michal Simek , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "sakari.ailus@linux.intel.com" , "hans.verkuil@cisco.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Dinesh Kumar , Sandip Kothari References: <1549025766-135037-1-git-send-email-vishal.sagar@xilinx.com> <1549025766-135037-2-git-send-email-vishal.sagar@xilinx.com> From: Luca Ceresoli Message-ID: <1f698576-89b2-e264-387e-6db4c5a4713a@lucaceresoli.net> Date: Mon, 11 Mar 2019 13:08:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_050816_181498_B5D8A93E X-CRM114-Status: UNSURE ( 7.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vishal, On 08/03/19 20:04, Vishal Sagar wrote: >>> +Optional properties: >>> +-------------------- >>> +- xlnx,vfb: This is present when Video Format Bridge is enabled. >>> + Without this property the driver won't be loaded as IP won't be able to >> generate >>> + media bus format compliant stream output. >>> +- xlnx,en-csi-v2-0: Present if CSI v2 is enabled in IP configuration. >>> +- xlnx,en-vcx: When present, there are maximum 16 virtual channels, else >>> + only 4. This is present only if xlnx,en-csi-v2-0 is present. >>> +- xlnx,en-active-lanes: Enable Active lanes configuration in Protocol >>> + Configuration Register. >> >> This doesn't seem very clear to me. According to my understanding of the >> IP and driver, I'd rather rephrase as: >> >> - xlnx,en-active-lanes: present if the number of active lanes can be >> reconfigured at runtime in the Protocol Configuration Register. >> If present, the V4L2_CID_XILINX_MIPICSISS_ACT_LANES is added. >> Otherwise all lanes are always active. >> > > Your description is better. I will update with this in next version. Ok, thanks. But I just noticed an error in my own words... "V4L2_CID_XILINX_MIPICSISS_ACT_LANES is added" -> "V4L2_CID_XILINX_MIPICSISS_ACT_LANES control is added". -- Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel