From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26839C4360C for ; Mon, 30 Sep 2019 08:24:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED1BA2086A for ; Mon, 30 Sep 2019 08:24:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PmtviYOr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="exPnKZEY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED1BA2086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ri6hyf2l+sGVhvIFLK9KuY8anqb0iKf81irELPduPB0=; b=PmtviYOrOFeM4sU/bN7ADPqthm ZCdDZeiCBQYYciL5rGOE/XmQ+n+a0zMVXww62v/2z1rXj4QiQ9a0cdlmS75sYDAw8ok6rtm97E10W 32yKHM1Mnkl+sUxP/fkUT4zf/6k/3xYt6F0Lv9DNeL0Mqy26fUQrKflPrquvi9hDNLbpjLxSWr0FT 2ekU7c+wdFG/gSW90BmbbjjFg6AXj6juu/IdgakhGlrFAmhBFpPjtFAlO88Y9kKrUWmPHR00JothF PR7uTBbaX2Pf16cHnvr8EQpW2nVPuBewEDxhRNJFBMTGQE+1i8gimNH8r1McyMgJYyidhrggpZNpo 1s8LKztQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEqyM-0002TO-DU; Mon, 30 Sep 2019 08:23:58 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEqwx-0001EG-No for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2019 08:22:33 +0000 Received: by mail-wm1-x341.google.com with SMTP id m18so11661405wmc.1 for ; Mon, 30 Sep 2019 01:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=ShSdTe5Qp8z7m+jUtvQKDuCvb0VtDo609FCfYvndEno=; b=exPnKZEYefJsNZMJjFnNmAXEv7dbG77oiHob/ywzmo4aeZfj7pFMylI2JIvFMtFjgz B0Ww5uxtxnbhyX3kcs03yySNcCTd2yQp9hgO5sZPs+M1dBZRpgnUz0HuKuoFHAyzNdAT Ay/W7zajAfCPVhaes66qjL57Qa8KBqYrGfmMm8viotFX+RiSbbh1Wh7h/S635yvrnk1X inAQ83q/tdXfSyKb8MedQCC2lK2kaCriTxVwcMqt/XG0ceO3g6NjOLaKS9Ao1MsGaQhv dwEwQHnevgCD3DOW4dRIx6XbE7NRex1y67oDlTVh4sDKiBaZJ6Mgm/WoPiNbYCId9AQs JXxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=ShSdTe5Qp8z7m+jUtvQKDuCvb0VtDo609FCfYvndEno=; b=PrWOdSDbLl3jkkpn68TufdkWHvoi5tdCJZV6rfrFC9cGBlQGJH51U85+u1j8ZSSYdl 4zmXd4UdYwtOq4NsfRBy6FE644nveYNnCGphdMiPZxnHdqzNbnBG/BvEkCA7fLa7baOO 3+TvO5UkQ9wjNQyqUXPRCZWzazv27Yjcs1uRblLJVZcf7IyjEZeagBf9GcYENxOOEE2l 0HMHn8rcRAz4Rux34X9GBI9oWQCuNern9tllOV/DBy3IgbjPAhJ08IZQDLZtVobMut4h 48JCHXYTzoOIk+3HHdJqkPa3fQCHRiqbACctzyHE9PSbgbQviFWB6e3T9jDopc2ozz9D O4kA== X-Gm-Message-State: APjAAAU3NfOuh0m+vpbz9nioXNr8RoJNEi7W5Ob6XXDOv3WP9dw3wO7S 06VINXat6oZuTx1xV2AHZAWs2g== X-Google-Smtp-Source: APXvYqyIM0BrCVvOADyXCOsoNjMjmm0DeuCYw4kWcFR08dZvDMjsgIDwDmqsdt3YFbfjPrmhjktI9A== X-Received: by 2002:a1c:cbcc:: with SMTP id b195mr17236045wmg.80.1569831749974; Mon, 30 Sep 2019 01:22:29 -0700 (PDT) Received: from localhost (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id l11sm14198165wmh.34.2019.09.30.01.22.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 01:22:29 -0700 (PDT) References: <20190925213528.21515-1-khilman@kernel.org> <20190925213528.21515-3-khilman@kernel.org> <8936e777-8996-5c7b-ea9d-8e17c8d6c4b1@baylibre.com> <7hwodulvu6.fsf@baylibre.com> <21eafa69-fe26-2df1-d187-cddfe5b37951@baylibre.com> User-agent: mu4e 1.3.3; emacs 26.2 From: Jerome Brunet To: linux-amlogic@lists.infradead.org, Kevin Hilman , Neil Armstrong Subject: Re: [PATCH v2 2/2] soc: amlogic: ee-pwrc: ensure driver state maches HW state In-reply-to: <21eafa69-fe26-2df1-d187-cddfe5b37951@baylibre.com> Date: Mon, 30 Sep 2019 10:22:28 +0200 Message-ID: <1jd0fi19dn.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190930_012231_806217_9AEC4C1C X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 27 Sep 2019 at 08:37, Neil Armstrong wrote: > On 26/09/2019 21:08, Kevin Hilman wrote: >> Neil Armstrong writes: >> >>> On 25/09/2019 23:35, Kevin Hilman wrote: >>>> From: Kevin Hilman >>>> >>>> During init, ensure that the driver on/off state as well as clock and >>>> reset state matches the hardware state. Do this by always calling the >>>> drivers 'on' function, and then callling the 'off' function if the >>>> HW state was initially detected as off. >> >> [...] >> >>> I don't see what you are trying to solve except simplifying the code. >> >> Simplifying the code is a worthwhile goal on its own, but that's not the >> only thing I'm tring to accomplish. > > I still find it ugly to power_on a domain to power it off right afterwards. > The issue is with the CCF enable handling which is not in sync with the > HW, if you boot with an already enabled clock, it won't be marked enabled > in CCF, and it's clearly bad when you want to have a fine-tuned gate state > handling. > CCF should disable unused clock so, in theory, you should not have to call enable() then disable() to get things in sync. I suppose the clock in question has the flag CLK_IGNORE_UNUSED (one of the gates) ? If the CLK_INGORE_UNUSED is becoming a problem, it would be better to fix the clock tree rather than adding quirks in consumers. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel