From: Jerome Brunet <jbrunet@baylibre.com>
To: Alexandre Mergnat <amergnat@baylibre.com>
Cc: narmstrong@baylibre.com, sboyd@kernel.org, khilman@baylibre.com,
Alexandre Mergnat <amergnat@baylibre.com>,
linux-kernel@vger.kernel.org, baylibre-upstreaming@groups.io,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: meson: axg-audio: migrate to the new parent description method
Date: Thu, 25 Jul 2019 16:38:24 +0200 [thread overview]
Message-ID: <1jd0hyxjq7.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20190722094954.14040-1-amergnat@baylibre.com>
On Mon 22 Jul 2019 at 11:49, Alexandre Mergnat <amergnat@baylibre.com> wrote:
> diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c
> index 8028ff6f6610..4253a466eae8 100644
> --- a/drivers/clk/meson/axg-audio.c
> +++ b/drivers/clk/meson/axg-audio.c
> @@ -15,7 +15,6 @@
> #include <linux/slab.h>
>
> #include "axg-audio.h"
> -#include "clk-input.h"
> #include "clk-regmap.h"
> #include "clk-phase.h"
> #include "sclk-div.h"
> @@ -24,7 +23,7 @@
> #define AUD_SLV_SCLK_COUNT 10
> #define AUD_SLV_LRCLK_COUNT 10
>
> -#define AUD_GATE(_name, _reg, _bit, _pname, _iflags) \
> +#define AUD_GATE(_name, _reg, _bit, _phws, _iflags) \
> struct clk_regmap aud_##_name = { \
> .data = &(struct clk_regmap_gate_data){ \
> .offset = (_reg), \
> @@ -33,13 +32,13 @@ struct clk_regmap aud_##_name = { \
> .hw.init = &(struct clk_init_data) { \
> .name = "aud_"#_name, \
> .ops = &clk_regmap_gate_ops, \
> - .parent_names = (const char *[]){ _pname }, \
> + .parent_hws = (const struct clk_hw *[]) { &_phws.hw }, \
Those '\' are aligned with tabs. please check, you have aligned a few
with spaces instead
> .num_parents = 1, \
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-07-25 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 9:49 [PATCH] clk: meson: axg-audio: migrate to the new parent description method Alexandre Mergnat
2019-07-25 14:38 ` Jerome Brunet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jd0hyxjq7.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=amergnat@baylibre.com \
--cc=baylibre-upstreaming@groups.io \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).