From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59271ECAAD4 for ; Mon, 29 Aug 2022 09:49:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:To:From:References:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RQJYtqy7Ch15C4PWVNQ8AgOw4NAfcZsfifptzJanqKo=; b=ZvKXCiRYru1qAt eEyu6ROH4aL/Ogp7q//wUHlisoDl7++BPWI+rl+ZTXPZOccVqydV3V4Qsl6+P2VVzYs9HKjIZhBHH Qo+bOlcrY/U2cAety/egTRXhJyiQk86iWzEQ98Ke7a8/wc4M9B7JIVWeg29JsUUVEORCLrZ+bLr2K o19kgOh3qJ6Pea+rpRB4mHtdsiDAtYdB9WAMQYkwqBLPdN47h2j2mmFbJTIzOp8AOQNewDH6MZs3t KjCuIdhzQEcY3utINy0CeH/Ej8TOr4sDLkN5/efkS/bCNDZzWL6syy/dMB31Xyl+4XSq3NA0PfpOy 6aDGW/+jtpxq205ehrNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSbNT-006vXX-8e; Mon, 29 Aug 2022 09:48:19 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSbNP-006vTS-4J for linux-arm-kernel@lists.infradead.org; Mon, 29 Aug 2022 09:48:16 +0000 Received: by mail-wr1-x42f.google.com with SMTP id n17so9459517wrm.4 for ; Mon, 29 Aug 2022 02:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:to:from:user-agent :references:from:to:cc; bh=yviMMnGD2NIBrfVD3zjnDAjWREiyBqmeaA8vluhbBlM=; b=MYtv7NXErfomVhACj4CvcivN5wiwJFqlN/QkD3Svj6b+WfT5ZQsEZdIQtNq5LdrJFa RMPVkYu7i4Ao/HAeEVdQI/hPwa0SOR7tS0YwhsxrvZMUfdd5jz1tEnycF0VAGFJgXxZt 4r2zyWzIvXrnVb4vivTUZvwWkFML9pIjnCB3FoRM9Y8V3Q4X+hXchhnV8fEF+FRyh9kg 4sfg6zLbTCqB391xVq4TU4s50ywE5qP/MQb03XMu2ewstmrrh316bKCwTNEJCmLNEYnk T0pV9Gz12E8gxs2Whz60vjZwFASEgdbJ+FM+vYHtNiJgXjTwNesDLcFAzehwL4QQyY1v sAcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:to:from:user-agent :references:x-gm-message-state:from:to:cc; bh=yviMMnGD2NIBrfVD3zjnDAjWREiyBqmeaA8vluhbBlM=; b=3Pqi/hbcyAWyXDsOIgy5xDynydm11cZiyjoSYHiYbnUo8sBfwVv5JvqMZwlR0UTDHV cDGgbLlLjKreSBKLYavXWauCIEVM5aA30zPwlRy+NwE/MjoBvSTlCaBCMxG04q1OnSDT 8byStpuFa8ObNWv5/uF+Q3OSiIwCPuERnzWSqQXkgHW0pxIYHIZaa73NmfRxsLACAcIU DWgCZq6bes09BR6eoWBPTh0CpEcx0dQY4zUBiyEPn3JD56lyCBd8WBcDsp4CkmTt+PiF ZKEDqSrjQrGy8qEHrkCDCoU5usqqjSIaRjGlYeYygJ8ChLpvkFmzMf8EmiL+g1pOY3iL qfMw== X-Gm-Message-State: ACgBeo0TX+BiRjCkvrrnd+G33pa/X6TJlfKxNzhz6ZQiSUhjR0cqXp15 27ZPSgcTtv6hZWaYQvRgo2KURQ== X-Google-Smtp-Source: AA6agR5lYEMVig3bo2NMgSo95EVg/KNxIK82zRJNlw7Kiy2jmOtoTniZzwOoPGDhG5XQe7+GIZSwaA== X-Received: by 2002:adf:ea91:0:b0:226:dce6:c344 with SMTP id s17-20020adfea91000000b00226dce6c344mr1354957wrm.3.1661766492719; Mon, 29 Aug 2022 02:48:12 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id bd22-20020a05600c1f1600b003a8436e2a94sm4385979wmb.16.2022.08.29.02.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 02:48:12 -0700 (PDT) References: <20220805085716.5635-1-yu.tu@amlogic.com> <20220805085716.5635-4-yu.tu@amlogic.com> <1jiln0yzgj.fsf@starbuckisacylon.baylibre.com> User-agent: mu4e 1.8.7; emacs 28.1 From: Jerome Brunet To: Yu Tu , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Neil Armstrong , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl Subject: Re: [PATCH V3 3/6] clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver Date: Mon, 29 Aug 2022 11:46:20 +0200 In-reply-to: Message-ID: <1jwnartm78.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_024815_253085_7E7CD438 X-CRM114-Status: GOOD ( 10.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 15 Aug 2022 at 14:34, Yu Tu wrote: > Hi Jerome, > > On 2022/8/10 21:47, Jerome Brunet wrote: >> [ EXTERNAL EMAIL ] >> On Fri 05 Aug 2022 at 16:57, Yu Tu wrote: >> */ [... ] >>> +#define ANACTRL_FIXPLL_CTRL0 (0x0010 << 2) >> I already commented on the "<< 2" . Remove them please. > Sorry, maybe I didn't pay attention to this comment earlier. A little bit > of a question why is this not okay? I understand isn't it better for the > compiler to help with this calculation itself? Because it is aweful to read Also please trim your replies. It is a bit annoying to search for your comments in the replies _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel