From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0763C35243 for ; Sat, 25 Jan 2020 11:20:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 817F52070A for ; Sat, 25 Jan 2020 11:20:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CYC+UiKW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 817F52070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CmWx6ABKtq6u8CO46Y1869NIjS18ES/4Rgh2zA7LU/M=; b=CYC+UiKWLQXIs7 s5Sf+Q4e4rYaBIRYDs5SlZVo8T2M6yPSaYgfqi8CbOjnfzay377QYV2fwlqJ49okLgwIhaP94hU9o 4AMSDSQ8x306acPXYPTfDhrt8s9fDKRJlfltvVqkR3uySWI+rFZm8zJacujMULnxQdg9/QTpt0gPO ksn2GbIP1i2/OiqgxuvYnSBjozeWWJ42ZTtJ94/kgFLUg90nm+6r9sVTFKVLJxHaKvvzP4WSUdSmy elghAjUYTiFf2tep64AXBQ1P/0pXgyeFJGiQyRdjNmaKipECKLgqPmXL0Y7n/XtUfErnd9CEi1geu WQPIxEeQwZ5U4mPFSbMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ivJUH-0005P2-1c; Sat, 25 Jan 2020 11:20:25 +0000 Received: from mailoutvs43.siol.net ([185.57.226.234] helo=mail.siol.net) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ivJUD-0005OV-Rb for linux-arm-kernel@lists.infradead.org; Sat, 25 Jan 2020 11:20:23 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 7DE3B520C74; Sat, 25 Jan 2020 12:20:19 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ydjZDDwb9wfv; Sat, 25 Jan 2020 12:20:19 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 2BF84520C7E; Sat, 25 Jan 2020 12:20:19 +0100 (CET) Received: from jernej-laptop.localnet (cpe-194-152-20-232.static.triera.net [194.152.20.232]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id AF879520C74; Sat, 25 Jan 2020 12:20:18 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai Subject: Re: [linux-sunxi] [PATCH 1/8] clk: sunxi-ng: sun8i-de2: Swap A64 and H6 definitions Date: Sat, 25 Jan 2020 12:20:18 +0100 Message-ID: <2008374.irdbgypaU6@jernej-laptop> In-Reply-To: References: <20200124232014.574989-1-jernej.skrabec@siol.net> <20200124232014.574989-2-jernej.skrabec@siol.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200125_032022_051203_43556A6C X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Stephen Boyd , Mike Turquette , linux-kernel , Maxime Ripard , linux-sunxi , Rob Herring , Hans Verkuil , Mauro Carvalho Chehab , linux-clk , linux-arm-kernel , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! Dne sobota, 25. januar 2020 ob 04:05:33 CET je Chen-Yu Tsai napisal(a): > On Sat, Jan 25, 2020 at 7:20 AM Jernej Skrabec wrote: > > For some reason, A64 and H6 have swapped clocks and resets definitions. > > H6 doesn't have rotation unit while A64 has. Swap around to correct the > > issue. > > > > Signed-off-by: Jernej Skrabec > > Could you add Fixes tags for this one? I'm not sure which commit to reference. H6 one? or also initial A64 one? I just found out that H5 compatible uses A64 structure, which is not correct. H5 doesn't contain rotate core. Do you have any better idea how to nicely solve this mess? I'm thinking that for v2 I would first decouple some compatibles, like this for H5 and R40 and V3s from A83T (as it can be seen in the next patch). After that, rather than switching definitions I would fix each compatible one by one. At the end, if any entry is duplicated, I can add one commit to merge same structures. What do you think? Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel