From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF676C433B4 for ; Mon, 26 Apr 2021 08:51:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CD5061131 for ; Mon, 26 Apr 2021 08:51:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CD5061131 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=773ndRciDCxODZ2hr6vhfi3qlXKk7A7/eaUAjl5Cds8=; b=W+medvgqHlnU86aPSxQvxnmpK Gb2EkA05dKA2Um6iS+SIkHslLiMSnJEIA7sOabiG/2G+HFp4NJiB/H9lwWTc+XjBLROXYfe760fKX 32ky1XoamyJo/Amp7Wr6S9GtGzcRmLqDCnx7SHeIjIxqRhz4Y5tWfDqF2371KfJxMoIFeVGycz2AD Sv3BUGQAyHxZqQ76GvaQfIiuhvuC+Jo4WzU5xKAhv0jU+VqHHuKHbmfH8lwznhSUOLM7Ip3IYmZFP KfgQw30n6io/+yQVgT5+XujF/qRH84nWsFKilKbaFZyeH64NCsy6RUenxX7GphP2RA/Zow8C/zIQE JfkP2O0Tw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lawwL-007Ek7-2d; Mon, 26 Apr 2021 08:50:01 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lawwI-007Ejm-1A for linux-arm-kernel@desiato.infradead.org; Mon, 26 Apr 2021 08:49:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=vDx/pF71DRswA0Vh9il3llHlvDpc9DTJuzBlhZnkZOs=; b=4/ivAe06xpFGlgu5Y+knRx3jy2 HF0UNgJ04MT8SsQNPExdCOUsv4sCAomuV22542so8UaYaRMzmJ9r3gZiQZGn7lCEve6I7MnNDHG2Y 6Xb2RyCzAddfALAb/RQm73CvNdtC+faxKy1H5OMBC12GNVlJ2E4hdg2uGlhADNaEj8OUK5UKN+Yu1 zbD5uxP6hpG9tMC4R2CNr/lFP7b/5hCTQjwN/wW/gyPNydyylnDIRCNeQwYTHiOs+G+W8aGNAFuTI zRSzbhed023/2mMcrW9ISDnkzZnosOVx5gFvmrEUfF81SB6PvjfHWQz1J6eUI+GjadD/1dIHZPnM6 wQtOvYyA==; Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lawwF-00Fq4O-J8 for linux-arm-kernel@lists.infradead.org; Mon, 26 Apr 2021 08:49:56 +0000 Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lawwE-0005Fl-92 for linux-arm-kernel@lists.infradead.org; Mon, 26 Apr 2021 08:49:54 +0000 Received: by mail-wr1-f72.google.com with SMTP id q18-20020adfc5120000b029010c2bdd72adso747767wrf.16 for ; Mon, 26 Apr 2021 01:49:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vDx/pF71DRswA0Vh9il3llHlvDpc9DTJuzBlhZnkZOs=; b=CfRzFbCWnmTZQ0aJ65FgnInYueGBosnreta7EaElNGV447tvjXeLgBCSJSZSR53jcl YBNHeyDMqngHRHdtUj3bPIFUCGi7r3B70hgz4th3IiN4j1oEeg1K5V4yOL/oVA0wtpV9 bj1+CrLG2715+NjGD2sDRiOo/zLvBPZL6boSRpVomxyB9xPNzquKNJmytBMFPPCKQfzc eFwMQDoDn3TPxykmlvWM0/mcTdYxZn78AEKvxU6ts5rAkKQujTmpeKxKi4PoOhr2XCEL iKBkBezcGR56OYJ3qUtC90CpdK68TGA03Xb4y3nUOGuYGT6OpFIV4cjltqgCyMfrtKRY vpcA== X-Gm-Message-State: AOAM530Z2Xobbbs7bPCmG9/mreu6aVgIW12Dr55h8IQLG7rF8tEoEPjh Ex7wVBwXjuyOCnbtEaeIotQi+YGGnGdXlJ5IdQdFCtH7ER4RFM/h/lckOyFwajp7RbiOGh5/NHU W8TLPyst1SmsZ35wrB8Sayf2kx+jsTgZ/iaFyoaJ5JwwrL7s3jWoA X-Received: by 2002:a5d:4c88:: with SMTP id z8mr21998724wrs.154.1619426993716; Mon, 26 Apr 2021 01:49:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMwlN7+/AG4RI2IBH83KYW2oysNRElSUN7qKGgzFn8jjG1AiNldJEiHnmlYdChvppLW2Jt9g== X-Received: by 2002:a5d:4c88:: with SMTP id z8mr21998707wrs.154.1619426993622; Mon, 26 Apr 2021 01:49:53 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-180-75.adslplus.ch. [188.155.180.75]) by smtp.gmail.com with ESMTPSA id s14sm19145030wrm.51.2021.04.26.01.49.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 01:49:53 -0700 (PDT) Subject: Re: [PATCH 04/10] memory: tegra: Make per-SoC setup more generic To: Thierry Reding Cc: Jon Hunter , Dmitry Osipenko , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210420165237.3523732-1-thierry.reding@gmail.com> <20210420165237.3523732-5-thierry.reding@gmail.com> From: Krzysztof Kozlowski Message-ID: <200ebdd4-bee0-caf3-e0b6-f4ba5e55b0e6@canonical.com> Date: Mon, 26 Apr 2021 10:49:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210420165237.3523732-5-thierry.reding@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_014955_794220_9811784C X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/04/2021 18:52, Thierry Reding wrote: > From: Thierry Reding > > The current per-SoC setup code runs at a fairly arbitrary point during > probe, thereby making it less flexible for other SoC generations. Move > the call around slightly, which will allow it to be used for other > implementations. You moved from one arbitrary point to another - please therefore explain the rationale of new arbitrary point a little bit more (e.g. after clock initialization? before HW access?) and put it next to struct tegra_mc_ops. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel