From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH 7/7] WIP: HACK/RFC: omap_device: begin to decouple platform_device from omap_device
Date: Sat, 30 Jul 2011 13:03:32 +0100 [thread overview]
Message-ID: <20110730120332.GA15539@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1311292338-11830-9-git-send-email-khilman@ti.com>
On Thu, Jul 21, 2011 at 04:52:18PM -0700, Kevin Hilman wrote:
> Rather than embedding a struct platform_device inside a struct
> omap_device, decouple them, leaving only a pointer to the
> platform_device inside the omap_device.
>
> This patch uses devres to allocate and attach the omap_device to the
> struct device, so finding an omap_device from a struct device means
> using devres_find(), and the to_omap_device() helper function was
> modified accordingly.
>
> RFC/Hack alert:
>
> Currently the driver core (drivers/base/dd.c) doesn't expect any
> devres resources to exist before the driver's ->probe() is called. In
> this patch, I just comment out the warning, but we'll need to
> understand why that limitation exists, and if it's a real limitation.
> A first glance suggests that it's not really needed. If this is a
> true limitation, we'll need to find some way other than devres to
> attach an omap_device to a struct device.
>
> On OMAP, we will need an omap_device attached to a struct device
> before probe because device HW may be disabled in probe and drivers
> are expected to use runtime PM in ->probe() to activate the hardware
> before access. Because the runtime PM API calls use omap_device (via
> our PM domain layer), we need omap_device attached to a
> platform_device before probe.
This feels really wrong to overload devres with this. devres purpose is
to provide the device's _drivers_ with a way to allocate and free resources
in such a way to avoid leaks on .remove or probe failure. So I think that
overloading it with something that has a different lifetime is completely
wrong.
We could add a new member to struct dev_archdata or pdev_archdata to carry
a pointer to this data, which I think would be a far cleaner (and saner)
way to deal with this. In much the same way as we already have an of_node
member in struct device.
next prev parent reply other threads:[~2011-07-30 12:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 23:52 [RFC/PATCH 0/7] decouple platform_device from omap_device Kevin Hilman
2011-07-21 23:52 ` [PATCH] OMAP: omap_device: replace _find_by_pdev() with to_omap_device() Kevin Hilman
2011-07-22 8:53 ` Felipe Balbi
2011-07-21 23:52 ` [RFC/PATCH 1/7] OMAP: omap_device: replace debug/warning/error prints with dev_* macros Kevin Hilman
2011-07-21 23:52 ` [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals Kevin Hilman
2011-07-22 8:57 ` Felipe Balbi
2011-07-28 5:53 ` Nishanth Menon
2011-07-28 10:10 ` Russell King - ARM Linux
2011-07-28 12:57 ` Cousson, Benoit
2011-07-28 12:59 ` Felipe Balbi
2011-07-28 13:31 ` Menon, Nishanth
2011-07-29 13:49 ` Nishanth Menon
2011-07-29 14:05 ` Felipe Balbi
2011-07-29 23:07 ` Menon, Nishanth
2011-08-01 8:52 ` Felipe Balbi
2011-07-28 8:36 ` Jean Pihet
2011-07-28 8:40 ` Jean Pihet
2011-07-21 23:52 ` [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices Kevin Hilman
2011-07-22 8:58 ` Felipe Balbi
2011-07-22 12:32 ` Sergei Shtylyov
2011-07-22 20:19 ` Kevin Hilman
2011-07-21 23:52 ` [RFC/PATCH 4/7] OMAP: omap_device: remove internal functions from omap_device.h Kevin Hilman
2011-07-21 23:52 ` [RFC/PATCH 5/7] OMAP: omap_device: when building return platform_device instead of omap_device Kevin Hilman
2011-07-21 23:52 ` [RFC/PATCH 6/7] OMAP: omap_device: device register functions now take platform_device pointer Kevin Hilman
2011-07-22 6:16 ` Grant Likely
2011-07-21 23:52 ` [RFC/PATCH 7/7] WIP: HACK/RFC: omap_device: begin to decouple platform_device from omap_device Kevin Hilman
2011-07-22 2:20 ` Grant Likely
2011-07-30 12:03 ` Russell King - ARM Linux [this message]
2011-07-31 2:58 ` Grant Likely
2011-07-31 15:05 ` Russell King - ARM Linux
2011-08-01 15:42 ` Kevin Hilman
2011-08-01 15:44 ` Grant Likely
2011-08-01 18:50 ` Felipe Balbi
2011-08-01 20:07 ` Russell King - ARM Linux
2011-08-01 22:11 ` Kevin Hilman
2011-08-01 22:55 ` Felipe Balbi
2011-08-01 23:09 ` Russell King - ARM Linux
2011-08-02 0:00 ` Grant Likely
2011-07-27 14:04 ` [RFC/PATCH 0/7] " G, Manjunath Kondaiah
2011-07-27 21:45 ` Hilman, Kevin
2011-07-28 4:50 ` G, Manjunath Kondaiah
2011-07-29 23:59 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110730120332.GA15539@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).