From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/12] ARM: mach-s5pv210: Setup consistent dma size at boot time
Date: Fri, 12 Aug 2011 15:09:30 +0000 [thread overview]
Message-ID: <20110812150929.GA5583@localhost.ucw.cz> (raw)
In-Reply-To: <1313068089.6698.12.camel@computer2>
On Thu 2011-08-11 14:08:09, Tixy wrote:
> On Thu, 2011-08-11 at 14:50 +0200, Pavel Machek wrote:
> >
> > > -#define CONSISTENT_DMA_SIZE (SZ_8M + SZ_4M + SZ_2M)
> > ...
> > > + init_consistent_dma_size(14 << 20);
> >
> > Are you sure that's equivalent?
>
> Yes. From include/asm-generic/sizes.h
>
> #define SZ_2M 0x00200000
> #define SZ_4M 0x00400000
> #define SZ_8M 0x00800000
>
> The max DMA size seems to be have been defined as 14MB at some point and
> several platforms define the size to be this value, but in different
> ways:
>
> SZ_16M - SZ_2M
> SZ_8M + SZ_4M + SZ_2M
> 14 << 20
>
> I chose to use just one for consistency, and (14 << 20) seemed clearer
> to me.
I missed the "4" in "14". Doing 14 *1024*1024 would be more usual way
of writing this...
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2011-08-12 15:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 14:28 [PATCH 0/12] ARM: Remove define CONSISTENT_DMA_SIZE Jon Medhurst
2011-08-08 14:28 ` [PATCH 01/12] ARM: Add init_consistent_dma_size() Jon Medhurst
2011-08-18 13:02 ` Nicolas Pitre
2011-08-08 14:28 ` [PATCH 02/12] ARM: omap: Setup consistent dma size at boot time Jon Medhurst
2011-08-08 14:28 ` [PATCH 03/12] ARM: mach-s3c64xx: " Jon Medhurst
2011-08-08 14:28 ` [PATCH 04/12] ARM: mach-s5p64x0: " Jon Medhurst
2011-08-08 14:28 ` [PATCH 05/12] ARM: mach-s5pv210: " Jon Medhurst
2011-08-11 12:50 ` Pavel Machek
2011-08-11 13:08 ` Tixy
2011-08-12 15:09 ` Pavel Machek [this message]
2011-08-08 14:28 ` [PATCH 06/12] ARM: mxc: " Jon Medhurst
2011-08-08 16:47 ` Sascha Hauer
2011-08-08 17:07 ` Tixy
2011-08-18 3:12 ` Nicolas Pitre
2011-08-18 8:13 ` Tixy
2011-08-18 18:51 ` Sascha Hauer
2011-08-19 9:08 ` Tixy
2011-08-19 17:00 ` Sascha Hauer
2011-08-22 11:05 ` Tixy
2011-08-22 11:37 ` Sascha Hauer
2011-08-08 14:28 ` [PATCH 07/12] ARM: mach-davinci: " Jon Medhurst
2011-08-08 14:28 ` [PATCH 08/12] ARM: mach-u300: " Jon Medhurst
2011-08-09 9:31 ` Linus Walleij
2011-08-08 14:28 ` [PATCH 09/12] ARM: mach-at91: " Jon Medhurst
2011-08-08 19:52 ` Nicolas Ferre
2011-08-08 14:28 ` [PATCH 10/12] ARM: mach-bcmring: " Jon Medhurst
2011-08-08 14:28 ` [PATCH 11/12] ARM: mach-shmobile: " Jon Medhurst
2011-08-08 14:28 ` [PATCH 12/12] ARM: Remove support for macro CONSISTENT_DMA_SIZE Jon Medhurst
2011-08-22 13:06 ` Submitting patchset: ARM: Remove define CONSISTENT_DMA_SIZE Tixy
2011-08-22 13:59 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812150929.GA5583@localhost.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).