From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem
Date: Thu, 09 Mar 2017 13:21:22 +0100 [thread overview]
Message-ID: <20128022.ebp5ZnzlHx@amdc3058> (raw)
In-Reply-To: <ab44a3c1-f078-4476-4583-de92ee68632c@cogentembedded.com>
Hi,
On Thursday, March 09, 2017 12:25:47 PM Sergei Shtylyov wrote:
> Hello!
>
> On 3/9/2017 11:39 AM, Sekhar Nori wrote:
>
> >>> It took a while to get to it but here is the draft driver patch
> >>> against v4.11-rc1. Please test.
> >>
> >> I tested this on DM6446 EVM. I was able to mount existing partitions on
> >> the hard disk and see that the directory listing looks good[1]. I will do
> >> more tests (including comparing performance with old driver) tomorrow. I
> >
> > I completed the tests I wanted to, including some read/write/data
> > integrity tests. Performance is same as before too.
> >
> > Tested-by: Sekhar Nori <nsekhar@ti.com>
> >
> > Here are the additional changes I did. These changes do not clash with
> > what I have already queued for v4.12. That said, its probably better if
> > I carry the platform pieces through my tree. Let me know how you want
> > to proceed.
> >
> > Thanks,
> > Sekhar
> >
> > ---8<---
> > diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig
> > index b9a7cb98ffda..67db82999c06 100644
> > --- a/arch/arm/configs/davinci_all_defconfig
> > +++ b/arch/arm/configs/davinci_all_defconfig
> [...]
> > diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
> > index 023480b75244..60a1f23890cd 100644
> > --- a/arch/arm/mach-davinci/board-dm644x-evm.c
> > +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
> > @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device *phydev)
> > return 0;
> > }
> >
> > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710)
> > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710)
>
> I think it would be more correct to check for both libata and IDE drivers
> here...
Thanks for noticing.
To make both drivers work depending on config options selected I'll:
- fix these HAS_ATA macros
- use "palm_bk3710" as platform driver name in the new driver
- drop IDE platform device & IDE clock name changes
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2017-03-09 12:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 15:24 [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: badge4_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: cerfcube_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: colibri_pxa270_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-16 9:01 ` Robert Jarzmik
2016-07-08 15:24 ` [RESEND PATCH] arm: lart_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: lpda270_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [PATCH v2] arm: mainstone_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: pxa255-idp_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: shannon_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: trizeps4_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 20:23 ` [RESEND PATCH] arm: assabet_defconfig: " Arnd Bergmann
2016-07-13 10:59 ` Bartlomiej Zolnierkiewicz
2016-07-13 14:37 ` Arnd Bergmann
2016-07-13 17:45 ` Russell King - ARM Linux
2016-07-14 9:59 ` Bartlomiej Zolnierkiewicz
2016-07-15 15:15 ` Kevin Hilman
2016-07-18 14:45 ` Sekhar Nori
2016-12-12 12:45 ` Bartlomiej Zolnierkiewicz
2016-12-12 13:54 ` Sekhar Nori
2017-03-07 17:51 ` Bartlomiej Zolnierkiewicz
2017-03-08 15:00 ` Sekhar Nori
2017-03-09 8:39 ` Sekhar Nori
2017-03-09 9:25 ` Sergei Shtylyov
2017-03-09 12:20 ` Sekhar Nori
2017-03-09 12:24 ` Sergei Shtylyov
2017-03-09 13:57 ` Russell King - ARM Linux
[not found] ` <CGME20170309144256epcas1p25b4c18f7ced857f71e2f8c53ce7b2345@epcas1p2.samsung.com>
2017-03-09 14:42 ` Bartlomiej Zolnierkiewicz
2017-03-09 14:51 ` Russell King - ARM Linux
[not found] ` <CGME20170309145745epcas5p331cf5418a586b8d435a508626cbf7af9@epcas5p3.samsung.com>
2017-03-09 14:57 ` Bartlomiej Zolnierkiewicz
2017-03-09 15:08 ` Russell King - ARM Linux
[not found] ` <CGME20170309154131epcas5p1f9c668855ee33c1634d4491d8664848b@epcas5p1.samsung.com>
2017-03-09 15:41 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20170309145219epcas5p38b1af654dd0a4b04bd02a488051c065f@epcas5p3.samsung.com>
2017-03-09 14:52 ` Bartlomiej Zolnierkiewicz
2017-03-09 16:22 ` Sergei Shtylyov
[not found] ` <CGME20170310171153epcas5p259bf9353fd1194dd131350fc59c3423a@epcas5p2.samsung.com>
2017-03-10 17:11 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20170309122125epcas5p415b1f2266f68d5b999d2eb4ced94e9f3@epcas5p4.samsung.com>
2017-03-09 12:21 ` Bartlomiej Zolnierkiewicz [this message]
[not found] ` <CGME20170309114756epcas5p3761bce85d5a8e3a095cb3a876c484ea6@epcas5p3.samsung.com>
2017-03-09 11:47 ` Bartlomiej Zolnierkiewicz
2017-03-09 11:57 ` Sekhar Nori
[not found] ` <CGME20170309121425epcas1p119ed8e5e27e3f7d8bfc71d0173cd301b@epcas1p1.samsung.com>
2017-03-09 12:14 ` Bartlomiej Zolnierkiewicz
2016-10-26 17:01 ` Bartlomiej Zolnierkiewicz
2016-10-31 15:46 ` Russell King - ARM Linux
2016-10-31 18:14 ` Bartlomiej Zolnierkiewicz
2016-10-31 18:24 ` Bartlomiej Zolnierkiewicz
2016-11-25 22:22 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20128022.ebp5ZnzlHx@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).