From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: smp_twd: change WARN() to pr_warn() on local timer register failure
Date: Thu, 21 Feb 2013 11:31:31 +0000 [thread overview]
Message-ID: <20130221113131.GZ17833@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1361435877-27252-1-git-send-email-shawn.guo@linaro.org>
On Thu, Feb 21, 2013 at 04:37:57PM +0800, Shawn Guo wrote:
> When booting a SMP build kernel with nosmp on kernel cmdline, the
> following fat warning will be hit. Since the local timer registeration
> failure is expected for such boot condition, a normal pr_warn message
> should be good enough for the failure.
Yes, a pr_warn here would be better. However, you're still going to end
up with a warning because we don't support this on UP.
The reason you don't get a warning when you build for UP is this:
#ifdef CONFIG_HAVE_ARM_TWD
void twd_local_timer_of_register(void);
#else
static inline void twd_local_timer_of_register(void)
{
}
#endif
twd_local_timer_of_register() becomes a no-op.
I think a better solution may be to also replicate this check:
if (!is_smp() || !setup_max_cpus)
in twd_local_timer_of_register() so that it also becomes a no-op.
prev parent reply other threads:[~2013-02-21 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 8:37 [PATCH] ARM: smp_twd: change WARN() to pr_warn() on local timer register failure Shawn Guo
2013-02-21 11:31 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221113131.GZ17833@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).