linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] i2c-core: dt: Pick i2c bus number from i2c alias if present
Date: Fri, 1 Mar 2013 20:22:13 +0100	[thread overview]
Message-ID: <20130301192212.GA379@the-dreams.de> (raw)
In-Reply-To: <1362157052-16738-2-git-send-email-dianders@chromium.org>

On Fri, Mar 01, 2013 at 08:57:31AM -0800, Doug Anderson wrote:
> This allows you to get the equivalent functionality of
> i2c_add_numbered_adapter() with all data in the device tree and no
> special case code in your driver.  This is a common device tree
> technique.
> 
> For quick reference, the FDT syntax for using an alias to provide an
> ID looks like:
>   aliases {
>     i2c0 = &i2c_0;
>     i2c1 = &i2c_1;
>   };
> 
> Signed-off-by: Doug Anderson <dianders@chromium.org>

Thanks, applied. I'll try to get it into 3.9.

> +	/* Handled by wrappers */
> +	if (WARN_ON(adap->nr == -1))
> +		return -EINVAL;

I removed this check, though. We know our callers, all static.

Thanks,

   Wolfram

  reply	other threads:[~2013-03-01 19:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12  0:48 [PATCH v3 0/2] Add automatic bus number support for i2c busses with device tree Doug Anderson
2013-02-12  0:48 ` [PATCH v3 1/2] i2c-core: dt: Pick i2c bus number from i2c alias if present Doug Anderson
2013-02-12  0:48 ` [PATCH v3 2/2] i2c: pxa: Use i2c-core to get bus number now Doug Anderson
2013-02-27  1:01 ` [PATCH v3 0/2] Add automatic bus number support for i2c busses with device tree Doug Anderson
2013-02-28 23:25   ` Wolfram Sang
2013-03-01  0:55     ` Doug Anderson
2013-03-01 16:57 ` [PATCH v4 " Doug Anderson
2013-03-01 16:57   ` [PATCH v4 1/2] i2c-core: dt: Pick i2c bus number from i2c alias if present Doug Anderson
2013-03-01 19:22     ` Wolfram Sang [this message]
2013-03-01 16:57   ` [PATCH v4 2/2] i2c: pxa: Use i2c-core to get bus number now Doug Anderson
2013-03-21 11:49     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130301192212.GA379@the-dreams.de \
    --to=wsa@the-dreams.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).