From: hannes@cmpxchg.org (Johannes Weiner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mm: Fixup the condition whether the page cache is free
Date: Mon, 4 Mar 2013 10:09:37 -0500 [thread overview]
Message-ID: <20130304150937.GB23767@cmpxchg.org> (raw)
In-Reply-To: <CAFNq8R7tq9kvD9LyhZJ-Cj0kexQfDsPhB4iQYyZ9s9+8Jo82QA@mail.gmail.com>
On Mon, Mar 04, 2013 at 09:54:26AM +0800, Li Haifeng wrote:
> When a page cache is to reclaim, we should to decide whether the page
> cache is free.
> IMO, the condition whether a page cache is free should be 3 in page
> frame reclaiming. The reason lists as below.
>
> When page is allocated, the page->_count is 1(code fragment is code-1 ).
> And when the page is allocated for reading files from extern disk, the
> page->_count will increment 1 by page_cache_get() in
> add_to_page_cache_locked()(code fragment is code-2). When the page is to
> reclaim, the isolated LRU list also increase the page->_count(code
> fragment is code-3).
The page count is initialized to 1, but that does not stay with the
object. It's a reference that is passed to the allocating task, which
drops it again when it's done with the page. I.e. the pattern is like
this:
instantiation:
page = page_cache_alloc() /* instantiator reference -> 1 */
add_to_page_cache(page, mapping, offset)
get_page(page) /* page cache reference -> 2 */
lru_cache_add(page)
get_page(page) /* pagevec reference -> 3 */
/* ...initiate read, write, associate buffers, ... */
page_cache_release(page) /* drop instantiator reference -> 2 + private */
reclaim:
lru_add_drain()
page_cache_release(page) /* drop pagevec reference -> 1 + private */
__isolate_lru_page(page)
page_cache_get(page) /* reclaim reference -> 2 + private */
is_page_cache_freeable(page)
try_to_free_buffers() /* drop buffer ref -> 2 */
__remove_mapping() /* drop page cache and isolator ref -> 0 */
free_hot_cold_page()
next prev parent reply other threads:[~2013-03-04 15:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 1:54 [PATCH] mm: Fixup the condition whether the page cache is free Li Haifeng
2013-03-04 15:09 ` Johannes Weiner [this message]
2013-03-05 1:51 ` Li Haifeng
2013-03-06 1:04 ` Simon Jeons
2013-03-06 19:47 ` Johannes Weiner
2013-03-07 1:05 ` Simon Jeons
2013-03-08 2:13 ` Simon Jeons
2013-03-08 2:37 ` Johannes Weiner
2013-03-08 2:48 ` Simon Jeons
2013-03-08 3:16 ` Johannes Weiner
2013-03-12 3:19 ` Simon Jeons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304150937.GB23767@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).