From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/3] ARM: mach-shmobile: r8a7740: Setup the serial devices using DT
Date: Tue, 5 Mar 2013 19:22:02 +0000 [thread overview]
Message-ID: <201303051922.02455.arnd@arndb.de> (raw)
In-Reply-To: <CABYn4sx=bC6JwicbVgRnmwdu=6DuW5GFgdG25a-Wow1Jn9M-bQ@mail.gmail.com>
On Tuesday 05 March 2013, Bastian Hecht wrote:
> 2013/3/4 Arnd Bergmann <arnd@arndb.de>:
> > On Monday 04 March 2013 17:20:54 Bastian Hecht wrote:
> >>
> >> + sci at e6c40000 {
> >> + compatible = "renesas,sci-SCIFA-uart";
> >> + interrupt-parent = <&intca>;
> >> + reg = <0xe6c40000 0x100>;
> >> + interrupts = <0x0c00>, <0x0c00>, <0x0c00>, <0x0c00>;
> >> + cell-index = <0>;
> >> + renesas,scscr = <0x30>;
> >> + renesas,scbrr-algo-id = <4>;
> >> + renesas,autoconf;
> >> + };
> >
> > The default name for a uart is "serial", I would recommend sticking to
> > that by convention. You may also want to add an "aliases" node
> > somewhere, to define which port should get which logical device number
> > on a given board.
>
> Switched to "...-serial".
I actually meant the name, not the "compatible" value. For compatible, either
version is fine with me. What I think you should change though is renaming
"sci at e6c40000" to "serial at e6c40000".
> About the aliases: Would I need to add that now, or can we postpone that?
>
No hurry for that. It's just a feature that comes in very handy, but not
all platforms implement it.
Arnd
prev parent reply other threads:[~2013-03-05 19:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 16:20 [PATCH v4 1/3] serial: sh-sci: Add OF support Bastian Hecht
2013-03-04 16:20 ` Arnd Bergmann
2013-03-05 12:58 ` Bastian Hecht
2013-03-05 19:26 ` Arnd Bergmann
2013-03-06 0:50 ` Paul Mundt
2013-03-06 10:19 ` Bastian Hecht
2013-03-06 10:28 ` Arnd Bergmann
2013-03-04 16:20 ` [PATCH v4 2/3] ARM: mach-shmobile: r8a7740: Add DT names to clock list Bastian Hecht
2013-03-04 16:20 ` [PATCH v4 3/3] ARM: mach-shmobile: r8a7740: Setup the serial devices using DT Bastian Hecht
2013-03-04 16:22 ` Arnd Bergmann
2013-03-05 13:00 ` Bastian Hecht
2013-03-05 13:42 ` Sergei Shtylyov
2013-03-05 13:47 ` Bastian Hecht
2013-03-05 19:22 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303051922.02455.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).