From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] usb: gadget: fix omap_udc build errors
Date: Wed, 6 Mar 2013 10:05:47 +0200 [thread overview]
Message-ID: <20130306080546.GC28587@arwen.pp.htv.fi> (raw)
In-Reply-To: <20130306004425.GA28448@kroah.com>
Hi,
On Wed, Mar 06, 2013 at 08:44:25AM +0800, Greg Kroah-Hartman wrote:
> On Wed, Mar 06, 2013 at 12:22:24AM +0200, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Mar 05, 2013 at 11:16:44PM +0100, Arnd Bergmann wrote:
> > > 1bf0cf6040 "usb: gadget: omap_udc: convert to udc_start/udc_stop"
> > > made some trivial changes but was missing a ';' character.
> > >
> > > 8c4cc00552 "ARM: OMAP1: DMA: Moving OMAP1 DMA channel definitions
> > > to mach-omap1" added a definition for OMAP_DMA_USB_W2FC_TX0 to
> > > the driver while making the header file it was defined in
> > > unavailable for drivers, but this driver actually needs
> > > OMAP_DMA_USB_W2FC_RX0 as well.
> > >
> > > Both changes appear trivial, so let's add the missing semicolon
> > > and the macro definition.
> > >
> > > Cc: Felipe Balbi <balbi@ti.com>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > > drivers/usb/gadget/omap_udc.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
> > > index 06be85c..f844565 100644
> > > --- a/drivers/usb/gadget/omap_udc.c
> > > +++ b/drivers/usb/gadget/omap_udc.c
> > > @@ -62,6 +62,7 @@
> > > #define DRIVER_VERSION "4 October 2004"
> > >
> > > #define OMAP_DMA_USB_W2FC_TX0 29
> > > +#define OMAP_DMA_USB_W2FC_RX0 26
> > >
> > > /*
> > > * The OMAP UDC needs _very_ early endpoint setup: before enabling the
> > > @@ -1310,7 +1311,7 @@ static int omap_pullup(struct usb_gadget *gadget, int is_on)
> > > }
> > >
> > > static int omap_udc_start(struct usb_gadget *g,
> > > - struct usb_gadget_driver *driver)
> > > + struct usb_gadget_driver *driver);
> >
> > good catch, thanks. I'll queue it for v3.6-rc3. Make sure to Cc
> > linux-usb for anything under drivers/usb/ though
>
> I think you mean 3.9 :)
right
> I can take this patch right now, if you ack it.
ok thanks:
Acked-by: Felipe Balbi <balbi@ti.com>
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130306/361e1fe6/attachment-0001.sig>
next prev parent reply other threads:[~2013-03-06 8:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 22:16 [PATCH 0/9] fixes for ARM build regressions in 3.9-rc1 Arnd Bergmann
2013-03-05 22:16 ` [PATCH 1/9] clk: vt8500: Fix "fix device clock divisor calculations" Arnd Bergmann
2013-03-05 22:16 ` [PATCH 2/9] Revert parts of "hlist: drop the node parameter from iterators" Arnd Bergmann
2013-03-05 22:16 ` [PATCH 3/9] mfd: remove __exit_p annotation for twl4030_madc_remove Arnd Bergmann
2013-03-06 1:01 ` Tony Lindgren
2013-03-05 22:16 ` [PATCH 4/9] usb: gadget: fix omap_udc build errors Arnd Bergmann
2013-03-05 22:22 ` Felipe Balbi
2013-03-06 0:44 ` Greg Kroah-Hartman
2013-03-06 8:05 ` Felipe Balbi [this message]
2013-03-05 22:16 ` [PATCH 5/9] ARM: omap1: add back missing includes Arnd Bergmann
2013-03-05 22:27 ` Arnd Bergmann
2013-03-06 0:59 ` Tony Lindgren
2013-03-06 11:23 ` Arnd Bergmann
2013-03-06 17:44 ` Tony Lindgren
2013-03-05 22:16 ` [PATCH 6/9] [media] ir-rx51: fix clock API related build issues Arnd Bergmann
2013-03-06 0:23 ` Mauro Carvalho Chehab
2013-03-06 1:09 ` Tony Lindgren
2013-03-06 6:22 ` Timo Kokkonen
2013-03-06 17:16 ` Tony Lindgren
2013-03-05 22:16 ` [PATCH 7/9] [media] s5p-fimc: fix s5pv210 build Arnd Bergmann
2013-03-06 23:48 ` Kukjin Kim
2013-03-05 22:16 ` [PATCH 8/9] iommu: OMAP: build only on OMAP2+ Arnd Bergmann
2013-03-06 1:10 ` Tony Lindgren
2013-03-09 18:02 ` Joerg Roedel
2013-03-05 22:16 ` [PATCH 9/9] ARM: spear3xx: Use correct pl080 header file Arnd Bergmann
2013-03-05 23:13 ` Viresh Kumar
2013-03-11 22:34 ` Arnd Bergmann
2013-03-12 0:53 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130306080546.GC28587@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).