linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue
Date: Wed, 6 Mar 2013 17:46:57 -0800	[thread overview]
Message-ID: <20130307014657.GA7426@quad.lixom.net> (raw)
In-Reply-To: <f20e3c5e822c4bd28a3b71264d73143cc1f850b0.1362458878.git.viresh.kumar@linaro.org>

On Tue, Mar 05, 2013 at 12:52:41PM +0800, Viresh Kumar wrote:
> +++ b/Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt
> @@ -0,0 +1,29 @@
> +Generic ARM big LITTLE cpufreq driver's DT glue
> +-----------------------------------------------
> +
> +It is DT specific glue layer for generic cpufreq driver for big LITTLE systems.
> +
> +Both required and optional properties listed below must be defined under node
> +cluster*. * can be 0 or 1.
> +
> +Required properties:
> +- freqs: List of all supported frequencies.
> +
> +Optional properties:
> +- clock-latency: Specify the possible maximum transition latency for clock, in
> +  unit of nanoseconds.
> +
> +Examples:
> +
> +cluster0: cluster at 0 {
> +        ..
> +
> +	freqs = <500000000 600000000 700000000 800000000 900000000 1000000000 1100000000 1200000000>;
> +	clock-latency = <200000>;
> +
> +	..
> +
> +        cores {
> +		..
> +        };
> +};

This binding makes no sense to me. It needs to be substantially better
documented, not just a couple of sentences that people that understand
bit.LITTLE thoroughly can make sense of.

It also duplicates the cpu binding. I suspect this should instead be done
through additions of the cpu bindings instead of duplication. So this needs to
be substantially reworked.


-Olof

  parent reply	other threads:[~2013-03-07  1:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05  4:52 [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue Viresh Kumar
2013-03-05 10:52 ` Russell King - ARM Linux
2013-03-05 16:38   ` Viresh Kumar
2013-03-06 17:25     ` Russell King - ARM Linux
2013-03-06 23:09       ` Viresh Kumar
2013-03-07  0:32   ` Viresh Kumar
2013-03-07  0:49     ` Harvey Harrison
2013-03-07  1:46       ` Viresh Kumar
2013-03-07  0:51     ` Russell King - ARM Linux
2013-03-07  2:03       ` Viresh Kumar
2013-03-07 11:49         ` Russell King - ARM Linux
2013-03-07 17:04           ` Viresh Kumar
2013-03-07  1:46 ` Olof Johansson [this message]
2013-03-07  1:50   ` Olof Johansson
2013-03-07  2:29     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130307014657.GA7426@quad.lixom.net \
    --to=olof@lixom.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).