From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 4/9] usb: chipidea: udc: add pullup/pulldown dp at hw_device_state
Date: Thu, 7 Mar 2013 11:50:54 +0200 [thread overview]
Message-ID: <20130307095054.GK9171@arwen.pp.htv.fi> (raw)
In-Reply-To: <20130307023612.GC20470@nchen-desktop>
Hi,
On Thu, Mar 07, 2013 at 10:36:13AM +0800, Peter Chen wrote:
> > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> > > index e82dae4..70f9f2d 100644
> > > --- a/drivers/usb/chipidea/udc.c
> > > +++ b/drivers/usb/chipidea/udc.c
> > > @@ -91,8 +91,10 @@ static int hw_device_state(struct ci13xxx *ci, u32 dma)
> > > /* interrupt, error, port change, reset, sleep/suspend */
> > > hw_write(ci, OP_USBINTR, ~0,
> > > USBi_UI|USBi_UEI|USBi_PCI|USBi_URI|USBi_SLI);
> > > + hw_write(ci, OP_USBCMD, USBCMD_RS, USBCMD_RS);
> > > } else {
> > > hw_write(ci, OP_USBINTR, ~0, 0);
> > > + hw_write(ci, OP_USBCMD, USBCMD_RS, 0);
> >
> > this patch doesn't make sense to me. What will happen is that you will
> > be enabling pullups when vbus_session() gets called and this might not
> > be what gadget driver wants.
> >
> > You don't want to fiddle with that yourself since I'm changing the
> > framework so that gadget driver will always request pullups to be
> > enabled.
>
> Hi Felipe,
>
> Do you think pullup dp without vbus is a valid operation?
why not ? What I want to connect pullups first and only then issue SRP ?
> Current udc core code makes that possible.
so ?
> But I think current your udc core code (add pullup after loading
> gadget) make benefit for udc driver who has not vbus operation.
>
> For chipidea driver:
>
> - If vbus is there before load gadget module, the pullup dp is done by
> udc core code.
> - If vbus is not there before load gadget module, the pullup will be
> done when the vbus is there.
This isn't legal. If you want to make sure vbus is alive before
connecting pullups, then do it generically. Modify udc-core.c to make
those checks for you. Bypassing the framework is dangerous because
whenever I wanna change something, I might miss your private details and
end up causing regressions.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130307/89379368/attachment.sig>
next prev parent reply other threads:[~2013-03-07 9:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 9:56 [PATCH v11 0/9] Add tested id switch and vbus connect detect support for Chipidea Peter Chen
2013-03-06 9:56 ` [PATCH v11 1/9] Revert "USB: chipidea: add vbus detect for udc" Peter Chen
2013-03-06 9:56 ` [PATCH v11 2/9] usb: chipidea: add otg file Peter Chen
2013-03-06 9:56 ` [PATCH v11 3/9] usb: chipidea: add otg id switch and vbus connect/disconnect detect Peter Chen
2013-03-06 17:09 ` Alexander Shishkin
2013-03-07 5:50 ` Peter Chen
2013-03-08 12:42 ` Peter Chen
2013-03-06 9:56 ` [PATCH v11 4/9] usb: chipidea: udc: add pullup/pulldown dp at hw_device_state Peter Chen
2013-03-06 11:26 ` Felipe Balbi
2013-03-07 2:36 ` Peter Chen
2013-03-07 9:50 ` Felipe Balbi [this message]
2013-03-08 1:28 ` Peter Chen
2013-03-08 7:18 ` Felipe Balbi
2013-03-08 8:05 ` Peter Chen
2013-03-06 9:56 ` [PATCH v11 5/9] usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS Peter Chen
2013-03-06 9:56 ` [PATCH v11 6/9] usb: chipidea: add vbus regulator control Peter Chen
2013-03-06 11:29 ` Felipe Balbi
2013-03-07 2:41 ` Peter Chen
2013-03-07 9:52 ` Felipe Balbi
2013-03-08 6:27 ` Peter Chen
2013-03-08 7:26 ` Felipe Balbi
2013-03-08 8:32 ` Peter Chen
2013-03-08 8:42 ` Felipe Balbi
2013-03-08 8:52 ` Peter Chen
2013-03-08 8:58 ` Felipe Balbi
2013-03-06 9:56 ` [PATCH v11 7/9] usb: chipidea: delete the delayed work Peter Chen
2013-03-06 9:56 ` [PATCH v11 8/9] usb: chipidea: imx: add getting vbus regulator code Peter Chen
2013-03-06 10:11 ` Felipe Balbi
2013-03-07 2:18 ` Peter Chen
2013-03-06 9:56 ` [PATCH v11 9/9] usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget Peter Chen
2013-03-06 18:46 ` Russell King - ARM Linux
2013-03-07 2:48 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307095054.GK9171@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).