linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/16] thermal: mvebu: Fix valid check for thermal register
Date: Thu, 21 Mar 2013 11:24:00 -0400	[thread overview]
Message-ID: <20130321152400.GX13280@titan.lakedaemon.net> (raw)
In-Reply-To: <20130321151609.GA24246@localhost>

On Thu, Mar 21, 2013 at 12:16:10PM -0300, Ezequiel Garcia wrote:
> Hi Jason,
> 
> On Thu, Mar 21, 2013 at 10:35:39AM -0400, Jason Cooper wrote:
> > On Wed, Mar 20, 2013 at 07:36:26PM -0300, Ezequiel Garcia wrote:
> > > The correct value is obtain by first shifting the register by the offset,
> > > later applying the valid mask and finally invert the result.
> > > This check was lacking an extra parenthesis to be strictly correct.
> > > 
> > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > > ---
> > >  drivers/thermal/mvebu_thermal.c |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > For the next version of this series, could you please put this fix first
> > in the series?  In this state, it can't be applied to v3.9-rcX, nor
> > -stable.
> > 
> 
> Given we're still discussing the aproach of this patchset.
> I think I prefer to send the fixes now, not as part of the
> current series but as independent patches.
> 
> What do you think?

I agree.

thx,

Jason.

  reply	other threads:[~2013-03-21 15:24 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 22:36 [PATCH 00/16] Marvell EBU thermal sensor consolidation Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 01/16] thermal: Rename driver 'kirkwood' -> 'mvebu' Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 02/16] thermal: mvebu: Rename symbols " Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 03/16] thermal: mvebu: Move MODULE_DEVICE_TABLE upwards Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 04/16] thermal: mvebu: Remove unneeded variable initialization Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 05/16] thermal: mvebu: Fix valid check for thermal register Ezequiel Garcia
2013-03-21 14:35   ` Jason Cooper
2013-03-21 15:16     ` Ezequiel Garcia
2013-03-21 15:24       ` Jason Cooper [this message]
2013-03-21 19:57         ` Ezequiel Garcia
2013-03-21 20:06           ` Jason Cooper
2013-03-20 22:36 ` [PATCH 06/16] thermal: mvebu: Convert to devm_ioremap_resource() Ezequiel Garcia
2013-03-21  6:10   ` Andrew Lunn
2013-03-21  9:43     ` Ezequiel Garcia
2013-03-21 10:08       ` Andrew Lunn
2013-03-21 14:04   ` Sergei Shtylyov
2013-03-21 15:17     ` Ezequiel Garcia
2013-03-21 19:17   ` Russell King - ARM Linux
2013-03-21 20:21     ` Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 07/16] thermal: mvebu: Fix license declaration Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 08/16] thermal: mvebu: Fix temperature output formula for kirkwood Ezequiel Garcia
2013-03-21 14:41   ` Jason Cooper
2013-03-21 19:20   ` Russell King - ARM Linux
2013-03-21 20:38     ` Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 09/16] thermal: mvebu: Rename kirkwood definitions to mvebu Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 10/16] thermal: mvebu: Add infrastructure to support more multiple SoC variants Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 11/16] thermal: mvebu: Add support for Armada XP thermal sensor Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 12/16] thermal: mvebu: Add support for Armada 370 " Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 13/16] thermal: mvebu: Add support for Marvell Dove SoC family Ezequiel Garcia
2013-03-21  6:23   ` Andrew Lunn
2013-03-21  6:26     ` Andrew Lunn
2013-03-20 22:36 ` [PATCH 14/16] ARM: mvebu: Add thermal support to Armada XP device tree Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 15/16] ARM: mvebu: Add thermal support to Armada 370 " Ezequiel Garcia
2013-03-21 14:03   ` Sergei Shtylyov
2013-03-21 15:18     ` Ezequiel Garcia
2013-03-20 22:36 ` [PATCH 16/16] ARM: configs: Update mvebu, dove and kirkwood defconfigs for thermal Ezequiel Garcia
2013-03-21  6:45 ` [PATCH 00/16] Marvell EBU thermal sensor consolidation Andrew Lunn
2013-03-21  9:42   ` Ezequiel Garcia
2013-03-21 12:35   ` Ezequiel Garcia
2013-03-21 13:36     ` Andrew Lunn
2013-03-21 17:32   ` Jason Gunthorpe
2013-03-22 14:23     ` Ezequiel Garcia
2013-03-21 12:26 ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130321152400.GX13280@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).