From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig
Date: Tue, 8 Jul 2014 10:15:44 +0200 [thread overview]
Message-ID: <20140708081542.GA23642@verge.net.au> (raw)
In-Reply-To: <66f679dbac764c329125a8ea50cd9ebd@HKXPR06MB168.apcprd06.prod.outlook.com>
On Mon, Jul 07, 2014 at 01:59:12PM +0000, Phil Edworthy wrote:
> Hi Sergei
>
> On 07 July 2014 14:54, Sergei wrote:
> > On 07/07/2014 05:23 PM, Simon Horman wrote:
> >
> > > The R-Car Gen 2 PCIe driver provides PCIe host support for
> > > Renesas R-Car Gen2 platforms. To increase hardware support enable
> > > the driver in the shmobile_defconfig multiplatform configuration.
> >
> > > Cc: Phil Edworthy <phil.edworthy@renesas.com>
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > ---
> > > arch/arm/configs/shmobile_defconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > > diff --git a/arch/arm/configs/shmobile_defconfig
> > b/arch/arm/configs/shmobile_defconfig
> > > index 5f05e98..6bc85a5 100644
> > > --- a/arch/arm/configs/shmobile_defconfig
> > > +++ b/arch/arm/configs/shmobile_defconfig
> > > @@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
> > > CONFIG_ARM_ERRATA_754322=y
> > > CONFIG_PCI=y
> > > CONFIG_PCI_RCAR_GEN2=y
> > > +CONFIG_PCI_RCAR_GEN2_PCIE=y
> >
> > Hmm, I'm not sure why the option has GEN2 -- the driver claims support for
> > R8A7779 as well as R8A779x. Probably the option should be renamed.
> Technically, you are correct. However, whilst the driver does support R8A7779, that device only supports 32-bit
> accesses over the PCIe bus so it's only useful for custom cards, not off-the-shelf PCIe cards.
It seems to me that dropping GEN2 from the config option may be a good idea.
But I believe that conversation is orthogonal to enabling the driver
in the defconfig. At this stage I plan to apply this patch.
next prev parent reply other threads:[~2014-07-08 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 13:23 [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig Simon Horman
2014-07-07 13:54 ` Sergei Shtylyov
2014-07-07 13:59 ` Phil Edworthy
2014-07-08 8:15 ` Simon Horman [this message]
2014-07-09 8:44 ` Simon Horman
2014-07-12 13:53 [GIT PULL] Third Round of Renesas ARM Based SoC Defconfig Updates for v3.17 Simon Horman
2014-07-12 13:53 ` [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708081542.GA23642@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).