From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW
Date: Thu, 17 Jul 2014 00:49:48 -0700 [thread overview]
Message-ID: <20140717074948.GF18374@atomide.com> (raw)
In-Reply-To: <1404825399-10330-1-git-send-email-mugunthanvnm@ti.com>
* Mugunthan V N <mugunthanvnm@ti.com> [140708 06:18]:
> Adding hwmod data for CPSW and MDIO which is present in DRA7xx SoC
>
> Cc: Rajendra Nayak <rnayak@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
>
> This patch was already send twice on 2013-10-18 and 2014-05-13. Adding
> more people in Cc to review the patch.
>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 65 +++++++++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 20b4398..45b5113 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -273,6 +273,56 @@ static struct omap_hwmod dra7xx_ctrl_module_wkup_hwmod = {
> };
>
> /*
> + * 'gmac' class
> + * cpsw/gmac sub system
> + */
> +static struct omap_hwmod_class_sysconfig dra7xx_gmac_sysc = {
> + .rev_offs = 0x0,
> + .sysc_offs = 0x8,
> + .syss_offs = 0x4,
> + .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE |
> + SYSS_HAS_RESET_STATUS),
> + .idlemodes = (SIDLE_FORCE | SIDLE_NO | MSTANDBY_FORCE |
> + MSTANDBY_NO),
> + .sysc_fields = &omap_hwmod_sysc_type3,
> +};
We seem to have this layout WR_SOFT_RESET and WR_CONTROL in the TRM:
WR_SOFT_RESET
[0] SOFT_RESET
WR_CONTROL
[3:2] MMR_STDBYMODE 0 = force-idle, 1 = no-standby
[1:0] MMR_IDLEMODE 0 = force-idle, 1 = no-idle
And so it seems to match what am33xx also has for am33xx_cpgmac_sysc
and am33xx TRM for 14.5.9 CONTROL register. So as far as I'm concerned:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2014-07-17 7:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 13:16 [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW Mugunthan V N
2014-07-09 9:55 ` Sebastian Andrzej Siewior
2014-07-09 10:01 ` Sebastian Andrzej Siewior
2014-07-09 10:11 ` Tony Lindgren
2014-07-15 20:21 ` Paul Walmsley
2014-07-16 7:06 ` Sebastian Andrzej Siewior
2014-07-16 18:57 ` Paul Walmsley
2014-07-17 7:50 ` Tony Lindgren
2014-07-22 18:53 ` Paul Walmsley
2014-07-17 7:49 ` Tony Lindgren [this message]
2014-07-22 10:11 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717074948.GF18374@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).