From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 4/8] ata: libahci: allow to use multiple PHYs
Date: Mon, 28 Jul 2014 13:27:24 -0400 [thread overview]
Message-ID: <20140728172724.GA7462@htj.dyndns.org> (raw)
In-Reply-To: <53D62624.6070502@redhat.com>
On Mon, Jul 28, 2014 at 12:29:56PM +0200, Hans de Goede wrote:
...
> > + if (!enabled_ports) {
> > + dev_warn(dev, "No port enabled\n");
> > + return ERR_PTR(-ENODEV);
>
> This should be:
> rc = -ENODEV;
> goto err_out;
>
> Sorry for not catching that sooner.
>
> Other then that the entire series looks good and is:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
Antoine, can you please post an updated version of this patch? No
need to repost the whole series. Also, how should the series be
routed?
Thanks.
--
tejun
next prev parent reply other threads:[~2014-07-28 17:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 9:17 [PATCH v11 0/8] ARM: berlin: add AHCI support Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 1/8] phy: add a driver for the Berlin SATA PHY Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 2/8] Documentation: bindings: add " Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 3/8] ata: libahci_platform: move port_map parameters into the AHCI structure Antoine Ténart
2014-07-29 14:40 ` Tejun Heo
2014-07-30 8:20 ` Antoine Ténart
2014-07-30 15:35 ` Tejun Heo
2014-07-30 16:47 ` Antoine Ténart
2014-07-30 16:50 ` Tejun Heo
2014-07-24 9:17 ` [PATCH v11 4/8] ata: libahci: allow to use multiple PHYs Antoine Ténart
2014-07-28 10:29 ` Hans de Goede
2014-07-28 17:27 ` Tejun Heo [this message]
2014-07-29 7:14 ` Antoine Ténart
2014-07-30 9:12 ` Kishon Vijay Abraham I
2014-07-24 9:17 ` [PATCH v11 5/8] ata: ahci_platform: add a generic AHCI compatible Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 6/8] Documentation: bindings: document the sub-nodes AHCI bindings Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 7/8] ARM: berlin: add the AHCI node for the BG2Q Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 8/8] ARM: berlin: enable the eSATA interface on the BG2Q DMP Antoine Ténart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728172724.GA7462@htj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).