From: rric@kernel.org (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC
Date: Tue, 5 Aug 2014 10:47:17 +0200 [thread overview]
Message-ID: <20140805084717.GH4703@rric.localhost> (raw)
In-Reply-To: <CAL_JsqKgfjV4sEZOWuH4YcMjeOA_yNDvZLv_jTi_Sb=27cOD3g@mail.gmail.com> <20140730174803.GF20162@leverpostej>
On 30.07.14 18:48:03, Mark Rutland wrote:
> > >> + uaa0: serial at 87e024000000 {
> > >> + compatible = "arm,pl011", "arm,primecell";
> > >> + reg = <0x87e0 0x24000000 0x0 0x1000>;
> > >> + interrupts = <1 21 4>;
> > >> + clocks = <&refclk50mhz>;
> > >> + clock-names = "apb_pclk";
> > >
> > > Is this actually the apb_pclk, or is the the uartclk? I assume it's the
> > > latter.
> >
> > Shouldn't new bindings have both clocks here? A single clock was a
> > mistake I think (mine in fact).
>
> I don't think we fixed it up in the end. It made drivers look a bit messy and
> it dropped off my priority queue.
On 31.07.14 10:22:19, Rob Herring wrote:
> On Thu, Jul 31, 2014 at 7:34 AM, Robert Richter <rric@kernel.org> wrote:
> > On 30.07.14 11:37:38, Rob Herring wrote:
> >> On Wed, Jul 30, 2014 at 10:46 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> >> > On Wed, Jul 30, 2014 at 04:06:31PM +0100, Robert Richter wrote:
> >> >> From: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> >> >> + uaa0: serial at 87e024000000 {
> >> >> + compatible = "arm,pl011", "arm,primecell";
> >> >> + reg = <0x87e0 0x24000000 0x0 0x1000>;
> >> >> + interrupts = <1 21 4>;
> >> >> + clocks = <&refclk50mhz>;
> >> >> + clock-names = "apb_pclk";
> >> >
> >> > Is this actually the apb_pclk, or is the the uartclk? I assume it's the
> >> > latter.
> >>
> >> Shouldn't new bindings have both clocks here? A single clock was a
> >> mistake I think (mine in fact).
> >
> > Do you mean
> > clock-names = "uartclk", "apb_pclk";
> > here?
>
> Yes, but Mark said this change never happened so maybe it is fine. In
> any case, follow the pl011 binding documentation.
Right:
Documentation/devicetree/bindings/arm/primecell.txt:
- clocks : From common clock binding. First clock is phandle to clock for apb
pclk. Additional clocks are optional and specific to those peripherals.
- clock-names : From common clock binding. Shall be "apb_pclk" for first clock.
Documentation/devicetree/bindings/serial/pl011.txt
- clocks: When present, must refer to exactly one clock named
"apb_pclk"
There is no binding documentation at all for "uartclk".
It seems we should should leave clock-names = "apb_pclk" as it is.
Mark, Rob, would this be ok?
Thanks,
-Robert
next prev parent reply other threads:[~2014-08-05 8:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 15:06 [PATCH 0/5] arm64, thunder: Enable Cavium Thunder SoC Family Robert Richter
2014-07-30 15:06 ` [PATCH 1/5] arm64, thunder: Add Kconfig option for " Robert Richter
2014-07-30 15:06 ` [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC Robert Richter
2014-07-30 15:46 ` Mark Rutland
2014-07-30 16:37 ` Rob Herring
2014-07-30 17:48 ` Mark Rutland
2014-08-05 8:47 ` Robert Richter [this message]
2014-07-31 11:32 ` Robert Richter
2014-07-31 12:34 ` Robert Richter
2014-07-31 15:22 ` Rob Herring
2014-07-31 16:35 ` Robert Richter
[not found] ` <CAFpQJXWKybVUxpHg8MVrVMjLj3swuxLGo_9r1tL+gZ4hxUHTzQ@mail.gmail.com>
2014-07-31 9:53 ` Mark Rutland
[not found] ` <CAFpQJXUtP=v7FSLd3_OU7FG3w=pKYy2ihTQULA_DPEacsSu0Og@mail.gmail.com>
2014-07-31 11:33 ` Mark Rutland
2014-08-01 17:04 ` Robert Richter
2014-08-01 18:00 ` Mark Rutland
2014-08-01 10:25 ` Robert Richter
2014-07-30 18:12 ` Olof Johansson
2014-07-30 18:35 ` Mark Rutland
2014-07-30 18:14 ` Olof Johansson
2014-08-01 16:18 ` Robert Richter
2014-08-28 16:15 ` Robert Richter
2014-08-28 16:25 ` Mark Rutland
2014-08-28 16:31 ` Olof Johansson
2014-08-28 18:14 ` Robert Richter
2014-08-28 23:01 ` Olof Johansson
2014-08-29 12:10 ` Robert Richter
2014-08-29 13:49 ` [PATCH] arm64, dts: Add dtbs_install make target Robert Richter
2014-09-05 6:55 ` Robert Richter
2014-07-31 10:24 ` [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC Arnd Bergmann
2014-07-31 11:33 ` Robert Richter
2014-07-30 15:06 ` [PATCH 3/5] arm64, thunder: document devicetree bindings " Robert Richter
2014-07-30 15:06 ` [PATCH 4/5] arm64, defconfig: Enable Cavium Thunder SoC in defconfig Robert Richter
2014-07-30 15:06 ` [PATCH 5/5] arm64, defconfig: Enable tmpfs mount option Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805084717.GH4703@rric.localhost \
--to=rric@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).