From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] spi: davinci: support adding delay between transmission
Date: Thu, 21 Aug 2014 13:20:35 -0500 [thread overview]
Message-ID: <20140821182035.GM24407@sirena.org.uk> (raw)
In-Reply-To: <1408634706-5762-3-git-send-email-grygorii.strashko@ti.com>
On Thu, Aug 21, 2014 at 06:25:06PM +0300, Grygorii Strashko wrote:
> +- ti,davinci-spi-wdelay : delay between transmissions.
I don't understand why this is here - there is already standard support
in the SPI core for client drivers specifying inter-transfer delays. If
there is a need to provide platform configuration for this in addition
to that then it should also be a standard property, there is nothing
device specific about these.
> +- ti,davinci-spi-odd-parity : odd partity enabled
> + OR
> + ti,davinci-spi-even-parity : even parity enabled
What do these mean?
> +- ti,davinci-spi-io-type: io type (check platform_data/spi-davinci.h)
The bindings should be independent of the kernel, the values need to be
included here (and the defines moved to include/dt-bindings so they can
be used when writing DTs).
> +- ti,davinci-spi-disable-timer: disable CS timer (SPIFMTn)
> +- ti,davinci-spi-c2t-delay: c2t delay
> +- ti,davinci-spi-t2c-delay: t2c delay
> +- ti,davinci-spi-t2e-delay: t2e delay
> +- ti,davinci-spi-c2e-delay: c2e delay
What are all these timers/delays - at least some reference to the
datasheet please?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140821/09a45eb3/attachment.sig>
next prev parent reply other threads:[~2014-08-21 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 15:25 [PATCH 0/2] spi: davinci: fixes and updates Grygorii Strashko
2014-08-21 15:25 ` [PATCH 1/2] spi: davinci: fix SPI_NO_CS functionality Grygorii Strashko
2014-08-21 18:10 ` Mark Brown
2014-08-21 15:25 ` [PATCH 2/2] spi: davinci: support adding delay between transmission Grygorii Strashko
2014-08-21 18:20 ` Mark Brown [this message]
2014-08-22 13:33 ` Grygorii Strashko
2014-08-22 15:06 ` Mark Brown
2014-09-05 14:21 ` Grygorii Strashko
2014-09-06 14:31 ` Mark Brown
2014-09-08 13:30 ` Grygorii Strashko
2014-09-08 14:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821182035.GM24407@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).