From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] arm64, thunder: Document devicetree bindings for Cavium Thunder SoC
Date: Fri, 5 Sep 2014 10:39:33 +0100 [thread overview]
Message-ID: <20140905093932.GI2172@leverpostej> (raw)
In-Reply-To: <20140905093222.GS4703@rric.localhost>
On Fri, Sep 05, 2014 at 10:32:22AM +0100, Robert Richter wrote:
> On 05.09.14 09:42:00, Will Deacon wrote:
> > On Fri, Sep 05, 2014 at 08:46:44AM +0100, Robert Richter wrote:
> > > From: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> > >
> > > This patch adds documentation for the devicetree bindings used by the
> > > DT files of Cavium Thunder SoC platforms.
> > >
> > > Signed-off-by: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> > > Signed-off-by: Robert Richter <rrichter@cavium.com>
> > > ---
> > > Documentation/devicetree/bindings/arm/cavium-thunder.txt | 10 ++++++++++
> > > Documentation/devicetree/bindings/arm/cpus.txt | 1 +
> > > 2 files changed, 11 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/arm/cavium-thunder.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/cavium-thunder.txt b/Documentation/devicetree/bindings/arm/cavium-thunder.txt
> > > new file mode 100644
> > > index 000000000000..6f63a5866902
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/arm/cavium-thunder.txt
> > > @@ -0,0 +1,10 @@
> > > +Cavium Thunder platform device tree bindings
> > > +--------------------------------------------
> > > +
> > > +Boards with Cavium's Thunder SoC shall have following properties.
> > > +
> > > +Root Node
> > > +---------
> > > +Required root node properties:
> > > +
> > > + - compatible = "cavium,thunder-88xx";
> >
> > Is this file necessary? We don't have one for xgene afaict.
>
> Hmm, looking at Documentation/devicetree/bindings/arm/calxeda.txt
> there is something similar.
>
> I am fine with both, keeping or removing it.
>
> Would leave this to the DT maintainers.
Having a required root node compatible is fine, though I would only
expect it to be necessary for errata workarounds if we have no other way
of detecting things.
That said, compatible strings shouldn't have wildcards, so
"cavium,thunder-88xx" should be replaced with something more specific.
Later boards can claim compatibility with that (but should have their
own strings too).
Mark.
next prev parent reply other threads:[~2014-09-05 9:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 7:46 [PATCH v2 0/4] arm64, thunder: Enable Cavium Thunder SoC Family Robert Richter
2014-09-05 7:46 ` [PATCH v2 1/4] arm64, thunder: Add Kconfig option for " Robert Richter
2014-09-05 8:39 ` Will Deacon
2014-09-05 9:21 ` Robert Richter
2014-09-05 9:25 ` Will Deacon
2014-09-05 9:36 ` Mark Rutland
2014-09-05 10:51 ` Robert Richter
2014-09-05 9:32 ` Russell King - ARM Linux
2014-09-05 10:45 ` Robert Richter
2014-09-05 11:05 ` Russell King - ARM Linux
2014-09-05 12:51 ` Mark Rutland
2014-09-05 14:04 ` Arnd Bergmann
2014-09-05 14:22 ` Mark Rutland
2014-09-05 16:25 ` Arnd Bergmann
2014-09-08 11:01 ` Robert Richter
2014-09-08 12:29 ` Arnd Bergmann
2014-09-08 18:25 ` Rob Herring
2014-09-05 7:46 ` [PATCH v2 2/4] arm64, thunder: Add initial dts for Cavium Thunder SoC Robert Richter
2014-09-05 11:21 ` Arnd Bergmann
2014-09-11 14:51 ` Robert Richter
2014-09-05 7:46 ` [PATCH v2 3/4] arm64, thunder: Document devicetree bindings " Robert Richter
2014-09-05 8:42 ` Will Deacon
2014-09-05 9:32 ` Robert Richter
2014-09-05 9:39 ` Mark Rutland [this message]
2014-09-08 7:54 ` Robert Richter
2014-09-05 7:46 ` [PATCH v2 4/4] arm64, defconfig: Enable Cavium Thunder SoC in defconfig Robert Richter
2014-09-05 8:42 ` [PATCH v2 0/4] arm64, thunder: Enable Cavium Thunder SoC Family Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905093932.GI2172@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).