From: peter.griffin@linaro.org (Peter Griffin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices
Date: Fri, 5 Sep 2014 19:16:36 +0100 [thread overview]
Message-ID: <20140905181636.GA1715@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <202755915.brE74x99uQ@wuerfel>
Hi Arnd,
On Fri, 05 Sep 2014, Arnd Bergmann wrote:
> On Friday 05 September 2014 18:23:45 Peter Griffin wrote:
> > +struct st_platform_priv {
> > + struct clk *clks[USB_MAX_CLKS];
> > + struct clk *clk48;
> > + struct reset_control *rst;
> > + struct reset_control *pwr;
> > + struct phy *phy;
> > +};
>
> Any reason why this is in a shared header file? It looks like
> duplicating the structure under two different names would
> actually be shorter and keep the drivers more readable as they'd
> be self-contained, even when they have the exact same structure.
The only reason was it was a identical structure so I put it in a shared
header file. I can unabstract it if you want?
>
> Do both drivers use all fields?
Yes they are. I thought the 48Mhz clock would only be used by ohci, but annoyingly it also
clocks the reset logic of the ehci block as well.
regards,
Peter.
next prev parent reply other threads:[~2014-09-05 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 17:23 [PATCH RESEND v5 0/5] Add EHCI and OHCI drivers for STi SoC's Peter Griffin
2014-09-05 17:23 ` [PATCH RESEND v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices Peter Griffin
2014-09-05 17:57 ` Arnd Bergmann
2014-09-05 18:16 ` Peter Griffin [this message]
2014-09-05 18:30 ` Arnd Bergmann
2014-09-05 17:23 ` [PATCH RESEND v5 2/5] usb: host: ohci-st: Add OHCI driver " Peter Griffin
2014-09-05 17:23 ` [PATCH RESEND v5 3/5] usb: host: ehci-st: Add ehci-st devicetree bindings documentation Peter Griffin
2014-09-05 17:23 ` [PATCH RESEND v5 4/5] usb: host: ohci-st: Add ohci-st " Peter Griffin
2014-09-05 17:23 ` [PATCH RESEND v5 5/5] MAINTAINERS: Add ehci-st.c and ohci-st.c to ARCH/STI architecture Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905181636.GA1715@griffinp-ThinkPad-X1-Carbon-2nd \
--to=peter.griffin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).