linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: morten.rasmussen@arm.com (Morten Rasmussen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 10/12] sched: get CPU's utilization statistic
Date: Mon, 15 Sep 2014 20:45:18 +0100	[thread overview]
Message-ID: <20140915194518.GC28083@e103687> (raw)
In-Reply-To: <20140911140444.GH4783@worktop.ger.corp.intel.com>

On Thu, Sep 11, 2014 at 03:04:44PM +0100, Peter Zijlstra wrote:
> On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote:
> > > Also I'm not entirely sure I like the usage, utilization names/metrics.
> > > I would suggest to reverse them. Call the pure running number
> > > 'utilization' and this scaled with capacity 'usage' or so.
> > 
> > ok. i can invert 'usage' and 'utilization', which will give
> > 
> > s/get_cpu_utilization/get_cpu_usage/
> > s/sgs->group_utilization/sgs->group_usage/

The confusion will have new dimensions added when we introduce
scale-invariance too. Then the running number is already scaled by the
current P-state compute capacity. But I don't have any better
suggestions. 

> > s/cfs.usage_load_avg/cfs.utilization_load_avg/

I don't like using "load" for unweighted metrics. I associate load with
something that may be weighted by priority like load_avg_contrib, and
utilization with pure cpu utilization as in how many cycles is spend on
a particular task. I called it "usage_util_avg" in my own patches, but
"util_avg" might be better if we agree that utilization == usage.

> > s/se->avg.usage_avg_contrib/se->avg.utilization_avg_contrib

util_avg_contrib maybe to keep it shorter.

> > s/__update_task_entity_usage/__update_task_entity_utilization
> > s/__update_entity_usage_avg_contrib/__update_entity_utilization_avg_contrib

Maybe use "util" here as well?

Morten

  parent reply	other threads:[~2014-09-15 19:45 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26 11:06 [PATCH v5 00/12] sched: consolidation of cpu_capacity Vincent Guittot
2014-08-26 11:06 ` [PATCH v5 01/12] sched: fix imbalance flag reset Vincent Guittot
2014-08-26 11:06 ` [PATCH v5 02/12] sched: remove a wake_affine condition Vincent Guittot
2014-08-26 11:06 ` [PATCH v5 03/12] sched: fix avg_load computation Vincent Guittot
2014-08-30 12:00   ` Preeti U Murthy
2014-09-03 11:09     ` Vincent Guittot
2014-09-03 23:43       ` Tim Chen
2014-09-04  7:17         ` Vincent Guittot
2014-09-04 16:26           ` Tim Chen
2014-09-05 11:10   ` Preeti U Murthy
2014-08-26 11:06 ` [PATCH v5 04/12] sched: Allow all archs to set the capacity_orig Vincent Guittot
2014-08-27 13:12   ` Kamalesh Babulal
2014-08-30 17:07   ` Preeti U Murthy
2014-09-01  8:05     ` Vincent Guittot
2014-09-03  8:41       ` Preeti U Murthy
2014-09-10 13:50     ` Peter Zijlstra
2014-09-10 14:22       ` Vincent Guittot
2014-09-11 10:36       ` Preeti U Murthy
2014-08-26 11:06 ` [PATCH v5 05/12] ARM: topology: use new cpu_capacity interface Vincent Guittot
2014-09-11 18:52   ` Nicolas Pitre
2014-08-26 11:06 ` [PATCH v5 06/12] sched: add per rq cpu_capacity_orig Vincent Guittot
2014-08-27 13:32   ` Kamalesh Babulal
2014-08-28  7:34     ` Vincent Guittot
2014-09-10 13:53   ` Peter Zijlstra
2014-09-10 14:19     ` Vincent Guittot
2014-09-11 19:02   ` Nicolas Pitre
2014-09-15 21:22     ` Vincent Guittot
2014-08-26 11:06 ` [PATCH v5 07/12] sched: test the cpu's capacity in wake affine Vincent Guittot
2014-09-10 14:19   ` Peter Zijlstra
2014-08-26 11:06 ` [PATCH v5 08/12] sched: move cfs task on a CPU with higher capacity Vincent Guittot
2014-08-30 17:50   ` Preeti U Murthy
2014-09-01  8:45     ` Vincent Guittot
2014-09-03  9:11       ` Preeti U Murthy
2014-09-03 11:44         ` Vincent Guittot
2014-09-03 12:26           ` Preeti U Murthy
2014-09-03 12:49             ` Vincent Guittot
2014-09-11  9:27             ` Peter Zijlstra
2014-09-05 12:06   ` Preeti U Murthy
2014-09-05 12:24     ` Vincent Guittot
2014-09-11 10:07   ` Peter Zijlstra
2014-09-11 11:20     ` Vincent Guittot
2014-09-11 10:13   ` Peter Zijlstra
2014-09-11 12:14     ` Vincent Guittot
2014-09-11 11:54   ` Peter Zijlstra
2014-08-26 11:06 ` [PATCH v5 09/12] sched: add usage_load_avg Vincent Guittot
2014-09-04  7:34   ` [PATCH v5 09/11] " Vincent Guittot
2014-09-11 11:17     ` Peter Zijlstra
2014-09-11 11:17   ` [PATCH v5 09/12] " Peter Zijlstra
2014-09-11 12:18     ` Vincent Guittot
2014-09-11 12:20     ` Vincent Guittot
2014-09-15 19:15   ` Morten Rasmussen
2014-09-15 22:33     ` Vincent Guittot
2014-08-26 11:06 ` [PATCH v5 10/12] sched: get CPU's utilization statistic Vincent Guittot
2014-09-11 12:34   ` Peter Zijlstra
2014-09-11 13:07     ` Vincent Guittot
2014-09-11 14:04       ` Peter Zijlstra
2014-09-11 19:17         ` Nicolas Pitre
2014-09-12  7:41           ` Vincent Guittot
2014-09-15 19:45         ` Morten Rasmussen [this message]
2014-09-16 22:43           ` Vincent Guittot
2014-09-15 19:28     ` Morten Rasmussen
2014-08-26 11:06 ` [PATCH v5 11/12] sched: replace capacity_factor by utilization Vincent Guittot
2014-09-11 15:39   ` Peter Zijlstra
2014-09-11 16:15   ` Peter Zijlstra
2014-09-11 17:26     ` Vincent Guittot
2014-09-14 19:41       ` Peter Zijlstra
2014-09-14 19:51         ` Peter Zijlstra
2014-09-15 11:42         ` Peter Zijlstra
2014-09-15 19:07           ` Nicolas Pitre
2014-09-15 20:01             ` Peter Zijlstra
2014-09-17 18:45               ` Morten Rasmussen
2014-09-17 18:58                 ` Morten Rasmussen
2014-09-17 23:03                 ` Peter Zijlstra
2014-09-15 22:14           ` Vincent Guittot
2014-09-15 22:18             ` Vincent Guittot
2014-09-17 22:25             ` Peter Zijlstra
2014-09-18  1:32               ` Vincent Guittot
2014-09-16 17:00         ` Dietmar Eggemann
2014-08-26 11:06 ` [PATCH v5 12/12] sched: add SD_PREFER_SIBLING for SMT level Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140915194518.GC28083@e103687 \
    --to=morten.rasmussen@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).