From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property
Date: Tue, 7 Oct 2014 13:35:14 +0100 [thread overview]
Message-ID: <20141007123514.GP24725@leverpostej> (raw)
In-Reply-To: <8401228.DSnFf2fgRn@wuerfel>
On Tue, Oct 07, 2014 at 01:31:23PM +0100, Arnd Bergmann wrote:
> On Tuesday 07 October 2014 13:08:12 Mark Rutland wrote:
> > On Tue, Oct 07, 2014 at 12:49:02PM +0100, Arnd Bergmann wrote:
> > > On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:
> > > > /* ALS and Proximity sensor */
> > > > isl29028 at 44 {
> > > > - compatible = "isil,isl29028";
> > > > + compatible = "isl,isl29028";
> > > > reg = <0x44>;
> > > > interrupt-parent = <&gpio>;
> > > > interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
> > > >
> > >
> > > Does this intentionally list only the new string?
> > >
> > > If we want compatibility between new dts files and old kernels, this would
> > > need to be
> > >
> > > compatible = "isl,isl29028", compatible = "isil,isl29028";
> >
> > Are we aiming for new dts wto work with old kernels? It's nice if they
> > do, but I don't think it should be necessary. Old DTBs should definitely
> > work with a new kernel, though.
> >
> > Personally I'd rather see one string (preferably the canonical one, but
> > the deprecated one is ok) than two strings when those strings are for
> > the exact same device.
> >
>
> Ok, fair enough. I think we should have the new name in dts files
> normally then, in order to avoid spreading the mistake further when
> someone copies it.
Sounds good to me.
Mark.
next prev parent reply other threads:[~2014-10-07 12:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 11:45 [PATCH v3 0/4] Correct vendor-prefix and document device isl29028 Darshana Padmadas
2014-10-07 11:45 ` [PATCH v3 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with " Darshana Padmadas
2014-10-07 11:46 ` Arnd Bergmann
2014-10-07 12:02 ` Mark Rutland
2014-10-07 12:17 ` Mark Rutland
2014-10-07 11:45 ` [PATCH v3 2/4] Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning Darshana Padmadas
2014-10-07 11:46 ` Arnd Bergmann
2014-10-07 12:03 ` Mark Rutland
2014-10-07 11:45 ` [PATCH v3 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028 Darshana Padmadas
2014-10-07 11:46 ` Arnd Bergmann
2014-10-07 12:08 ` Mark Rutland
2014-10-07 11:45 ` [PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property Darshana Padmadas
2014-10-07 11:49 ` Arnd Bergmann
2014-10-07 12:08 ` Mark Rutland
2014-10-07 12:31 ` Arnd Bergmann
2014-10-07 12:35 ` Mark Rutland [this message]
[not found] ` <CAEZObdLz-77b41tE=TLb0iFyhOsAyW+UV7YfAyFbMYRBJvRwTg@mail.gmail.com>
2014-10-07 13:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007123514.GP24725@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).