From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: /proc/cpuinfo: Use DT machine name when possible
Date: Mon, 24 Nov 2014 23:29:54 +0100 [thread overview]
Message-ID: <201411242329.54361@pali> (raw)
In-Reply-To: <540B2997.4070600@suse.de>
On Saturday 06 September 2014 17:34:47 Andreas F?rber wrote:
> Am 05.09.2014 15:52, schrieb Pali Roh?r:
> > On Friday 05 September 2014 15:45:42 Mark Rutland wrote:
> >> On Fri, Sep 05, 2014 at 12:38:40PM +0100, Pali Roh?r wrote:
> >>> On Wednesday 18 June 2014 18:54:24 Pali Roh?r wrote:
> >>>> Machine name from board description is some generic name
> >>>> on DT kernel. DT provides machine name property which is
> >>>> specific for board, so use it instead generic one when
> >>>> possible.
> >>>>
> >>>> Signed-off-by: Pali Roh?r <pali.rohar@gmail.com>
> >>>> ---
> >>>>
> >>>> arch/arm/kernel/setup.c | 7 +++++--
> >>>> 1 file changed, 5 insertions(+), 2 deletions(-)
> >>>>
> >>>> diff --git a/arch/arm/kernel/setup.c
> >>>> b/arch/arm/kernel/setup.c index 8a16ee5..fbc7b4f 100644
> >>>> --- a/arch/arm/kernel/setup.c
> >>>> +++ b/arch/arm/kernel/setup.c
> >>>> @@ -875,10 +875,13 @@ void __init setup_arch(char
> >>>> **cmdline_p)
> >>>>
> >>>> setup_processor();
> >>>> mdesc = setup_machine_fdt(__atags_pointer);
> >>>>
> >>>> - if (!mdesc)
> >>>> + if (mdesc)
> >>>> + machine_name = of_flat_dt_get_machine_name();
> >>>> + else
> >>>>
> >>>> mdesc = setup_machine_tags(__atags_pointer,
> >>>>
> >>>> __machine_arch_type); machine_desc = mdesc;
> >>>> - machine_name = mdesc->name;
> >>>> + if (!machine_name)
> >>>> + machine_name = mdesc->name;
> >>>>
> >>>> if (mdesc->reboot_mode != REBOOT_HARD)
> >>>>
> >>>> reboot_mode = mdesc->reboot_mode;
> >>>
> >>> So, do you really want to break userspace which reading
> >>> file /proc/cpuinfo (after migration from boardcode -->
> >>> DT)?
> >>
> >> You have no guarantee model name in the DT == the name in a
> >> board file anyhow, and trying to force that is wrong. So
> >> further to Russell's reply, I must NAK this from a DT
> >> perspective.
> >>
> >> Realistically your userspace is already broken if relying
> >> on such things. You built something that only ever worked
> >> for a particular arbitrary string. So it was already
> >> broken for every other board, and there was never any
> >> guarantee that new boards where your userspace could have
> >> worked would share the same name.
> >>
> >> You're trying to fix the wrong side of the equation.
> >
> > So what is your suggestion for identifing board (name/type)
> > which will work with any kernel (and will not be broken
> > again by kernel later)?
>
> /proc/device-tree/compatible should give you a nul-separated
> list of compatible strings for the machine. Ideally they're
> even documented under Documentation/devicetree/bindings/arm/.
>
> But as Mark said, depending on what you are actually trying to
> distinguish in userspace, there may be better ways.
>
> Regards,
> Andreas
Ok, this is better. It at least output that device is Nokia N900
and not some generic omap device...
$ cat /proc/device-tree/compatible
nokia,omap3-n900ti,omap3430ti,omap3
But I need also serial number and hw revisions which are reported
by bootloader in ATAGs.
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141124/a2955bc8/attachment-0001.sig>
prev parent reply other threads:[~2014-11-24 22:29 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 16:54 [PATCH] ARM: /proc/cpuinfo: Use DT machine name when possible Pali Rohár
2014-06-18 19:01 ` Russell King - ARM Linux
2014-06-18 19:09 ` Pali Rohár
2014-06-18 19:59 ` Russell King - ARM Linux
2014-06-19 8:21 ` Pavel Machek
2014-07-11 19:31 ` Pavel Machek
2014-06-18 19:07 ` Rob Herring
2014-06-18 19:22 ` Pali Rohár
2014-06-18 20:00 ` Russell King - ARM Linux
2014-06-18 20:20 ` Pali Rohár
2014-06-18 21:53 ` Fabio Estevam
2014-11-24 22:16 ` Pali Rohár
2014-06-18 20:46 ` Rob Herring
2014-06-18 21:47 ` Russell King - ARM Linux
2014-06-18 22:27 ` Rob Herring
2014-06-18 23:07 ` Russell King - ARM Linux
2014-11-24 22:19 ` Pali Rohár
2014-12-04 0:33 ` Rob Herring
2014-12-04 0:48 ` Pali Rohár
2014-12-04 16:49 ` Rob Herring
2014-12-04 17:57 ` Pali Rohár
2014-12-04 18:10 ` Rob Herring
2015-01-26 19:09 ` [PATCH] ARM: /proc/cpuinfo: DT: Add support for Revision Pali Rohár
2015-01-26 20:22 ` Rob Herring
2015-01-30 14:14 ` Pali Rohár
2015-01-30 21:03 ` Rob Herring
2015-02-27 15:45 ` Pali Rohár
2015-02-27 15:55 ` [PATCH v2 0/2] " Pali Rohár
2015-02-27 15:55 ` [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision Pali Rohár
2015-02-27 15:55 ` [PATCH v2 2/2] arm: boot: convert ATAG_REVISION to DT revision field Pali Rohár
2015-03-02 11:28 ` [PATCH v2 0/2] ARM: /proc/cpuinfo: DT: Add support for Revision Pavel Machek
2015-03-16 15:44 ` Tony Lindgren
2015-03-16 16:14 ` Russell King - ARM Linux
2015-03-16 16:43 ` Nicolas Pitre
2015-03-16 19:21 ` Russell King - ARM Linux
2015-03-16 18:10 ` Tony Lindgren
2015-03-16 19:59 ` Russell King - ARM Linux
2015-03-16 20:54 ` Pali Rohár
2015-03-16 20:59 ` Tony Lindgren
2015-01-26 22:34 ` [PATCH] " Andreas Färber
2015-02-27 15:56 ` Pali Rohár
2015-01-26 19:16 ` [PATCH] ARM: /proc/atags: Export also for DT Pali Rohár
2015-01-26 20:33 ` Rob Herring
2015-01-27 13:21 ` Pavel Machek
2015-01-27 14:16 ` Rob Herring
2015-01-27 14:24 ` Pavel Machek
2015-01-27 14:32 ` Pali Rohár
2015-01-27 17:48 ` Russell King - ARM Linux
2015-01-27 20:03 ` Nicolas Pitre
2015-01-27 21:09 ` Russell King - ARM Linux
2015-01-27 21:34 ` Nicolas Pitre
2015-01-27 21:58 ` Nicolas Pitre
2015-01-27 22:33 ` Russell King - ARM Linux
2015-01-28 2:07 ` Nicolas Pitre
2015-01-28 6:21 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-28 7:19 ` Pavel Machek
2015-01-28 8:06 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-28 8:25 ` Pavel Machek
2015-01-28 7:18 ` Pavel Machek
2015-01-28 13:38 ` Pali Rohár
2015-01-27 23:10 ` Pavel Machek
2015-01-28 0:50 ` Tony Lindgren
2015-01-28 13:58 ` Pali Rohár
2015-01-28 14:33 ` Nicolas Pitre
2015-01-28 15:39 ` Tony Lindgren
2015-01-28 15:47 ` Pali Rohár
2015-01-28 15:48 ` Tony Lindgren
2015-01-28 16:31 ` Jason Cooper
2015-01-28 15:57 ` Rob Herring
2015-01-28 16:13 ` Russell King - ARM Linux
2015-01-28 16:19 ` Will Deacon
2015-01-28 17:01 ` Russell King - ARM Linux
2015-01-28 17:29 ` Russell King - ARM Linux
2015-01-28 17:18 ` Pali Rohár
2015-01-28 18:00 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-28 19:33 ` Pali Rohár
2015-01-28 18:03 ` Pavel Machek
2015-01-28 19:27 ` Arnd Bergmann
2015-01-28 14:46 ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-27 19:40 ` Nicolas Pitre
2015-01-26 20:37 ` Russell King - ARM Linux
2015-01-26 20:44 ` Pali Rohár
2014-12-04 19:00 ` [PATCH] ARM: /proc/cpuinfo: Use DT machine name when possible Pali Rohár
2014-12-04 10:59 ` Russell King - ARM Linux
2014-06-18 21:10 ` Aaro Koskinen
2014-07-11 19:28 ` Pavel Machek
2014-11-24 22:21 ` Pali Rohár
2014-09-05 11:38 ` Pali Rohár
2014-09-05 12:13 ` Russell King - ARM Linux
2014-09-10 12:46 ` Pavel Machek
2014-11-24 22:23 ` Pali Rohár
2014-09-05 13:45 ` Mark Rutland
2014-09-05 13:52 ` Pali Rohár
2014-09-05 13:58 ` Mark Rutland
2014-11-24 22:25 ` Pali Rohár
2014-09-05 13:58 ` Fabio Estevam
2014-11-24 22:27 ` Pali Rohár
2014-09-06 15:34 ` Andreas Färber
2014-11-24 22:29 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411242329.54361@pali \
--to=pali.rohar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).