linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/8] Fix struct clk pointer comparing
Date: Thu, 26 Feb 2015 09:21:39 +0800	[thread overview]
Message-ID: <20150226012121.GC20028@dragon> (raw)
In-Reply-To: <54EE33C5.5010701@codeaurora.org>

On Wed, Feb 25, 2015 at 12:42:45PM -0800, Stephen Boyd wrote:
> On 02/25/15 09:55, Mike Turquette wrote:
> > Quoting Russell King - ARM Linux (2015-02-25 07:03:49)
> >> Case 1 applies in places like the Kirkwood I2S driver, and the iMX6
> >> ethernet code, and it's these cases which need to be fixed.
> >>
> >> Case 2 applies in the Armada DRM driver, and these cases need not be
> >> "fixed".
> >>
> >> To put it a different way: case 1 is when you're testing to see whether
> >> two clocks refer to the same clock.  case 2 is when you're testing
> >> whether the cached clk cookie is the same.
> > It looks like patches 2, 7 and 8 are correct in this series. I'll apply
> > them towards -rc2 if nobody objects.
> >
> >
> 
> For patch 8 can't we use the alternative patch that I came up with
> before? I have a patch for sound/soc/fsl/fsl_esai.c and
> drivers/pwm/pwm-atmel-hlcdc.c which I can send shortly.

This beats the idea of clk_is_match() helper.  I prefer to fix this
generic problem in a generic way, i.e. using clk_is_match(), which
should be much easier and safer during -rc cycle.

Shawn

  reply	other threads:[~2015-02-26  1:21 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 14:53 [PATCH 0/8] Fix struct clk pointer comparing Shawn Guo
2015-02-25 14:53 ` [PATCH 1/8] clk: add helper function clk_is_match() Shawn Guo
2015-02-25 17:27   ` Mike Turquette
2015-02-26  0:37     ` Shawn Guo
2015-02-26  9:02     ` [alsa-devel] " Ben Dooks
2015-02-26  9:56       ` Philipp Zabel
2015-02-26 11:25         ` Ben Dooks
2015-02-26 11:59           ` Ricard Wanderlof
2015-03-04  8:55     ` Geert Uytterhoeven
2015-03-04  9:51     ` Russell King - ARM Linux
2015-03-08 21:05     ` [PATCH] clk: provide clk_is_match() dummy for non-common clk Arnd Bergmann
2015-03-10 21:42       ` Geert Uytterhoeven
2015-03-11  7:09       ` Uwe Kleine-König
2015-03-11 10:22       ` Russell King - ARM Linux
2015-03-11 11:17         ` Uwe Kleine-König
2015-03-11 12:29           ` Russell King - ARM Linux
2015-03-12  0:35             ` Stephen Boyd
2015-02-25 14:53 ` [PATCH 2/8] ARM: imx: fix struct clk pointer comparing Shawn Guo
2015-02-25 14:53 ` [PATCH 3/8] drm: armada: " Shawn Guo
2015-02-25 14:53 ` [PATCH 4/8] pwm: atmel-hlcdc: " Shawn Guo
2015-02-26  9:22   ` Nicolas Ferre
2015-02-26  9:31     ` Boris Brezillon
2015-03-11 10:54   ` Thierry Reding
2015-02-25 14:53 ` [PATCH 5/8] serial: samsung: " Shawn Guo
2015-02-25 14:53 ` [PATCH 6/8] ASoC: fsl_esai: " Shawn Guo
2015-02-26  2:36   ` Mark Brown
2015-02-25 14:53 ` [PATCH 7/8] ASoC: fsl_spdif: " Shawn Guo
2015-02-25 21:04   ` Stephen Boyd
2015-02-26  1:17     ` Shawn Guo
2015-02-26  2:12   ` Mark Brown
2015-02-26  2:20     ` Shawn Guo
2015-02-26  2:29       ` Mark Brown
2015-02-26  2:36   ` Mark Brown
2015-02-25 14:53 ` [PATCH 8/8] ASoC: kirkwood: " Shawn Guo
2015-02-26  2:12   ` Mark Brown
2015-02-26  2:36   ` Mark Brown
2015-02-25 15:03 ` [PATCH 0/8] Fix " Russell King - ARM Linux
2015-02-25 17:55   ` Mike Turquette
2015-02-25 20:42     ` Stephen Boyd
2015-02-26  1:21       ` Shawn Guo [this message]
2015-02-26  1:24       ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150226012121.GC20028@dragon \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).