From: Liviu.Dudau@arm.com (Liviu Dudau)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: juno: Add APB registers and LEDs using syscon
Date: Mon, 9 Mar 2015 10:12:05 +0000 [thread overview]
Message-ID: <20150309101205.GY16268@e106497-lin.cambridge.arm.com> (raw)
In-Reply-To: <CACRpkdZq9n1+3sBi3g-ZTa9TaC3_PsO3ecox2gu7Vq-0rouXxw@mail.gmail.com>
On Sat, Mar 07, 2015 at 10:24:08PM +0000, Linus Walleij wrote:
> On Fri, Feb 27, 2015 at 3:06 PM, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
> > On Fri, Feb 27, 2015 at 01:07:42PM +0000, Linus Walleij wrote:
>
> >> Notice that the SD card slot is *ALSO* inside the box, do you mean we
> >> should then also delete the uSD card support added in
> >> commit 71f867ec130e3cc8e692366fdf8941ded27c727e
> >> by yourself because the SD card slot is not reachable?
> >> Notice that to access that card slot you even have to remove the
> >> nice blue ARM boilerplate.
> >
> > That's not my view. I have a mobile phone with an uSD card slot, but I have to take
> > the cover off (and the battery) to access it. It doesn't mean I should not be able
> > to use it from kernel side because of that, only that the designer of the phone
> > (and of the Juno board + box by extension) did not expect people to use it with
> > covers off all the time.
> >
> > <virtual-tongue-in-cheek-on>
> > I fail to see why you need to remove the SD card all the time. Surely opening
> > the case once to put the uSD card in is enough? ;)
> > </virtual-tongue-in-cheek-on>
> >
> >>
> >> The board is obviously designed to be reachable and the top part
> >> of the case is obviously designed to be taken off by professional
> >> users.
> >
> > I'm mostly on your side, Linus, I was just looking for more use cases. Like I've said,
> > most of our customers seem to keep the case closed (or at least that is what they tell
> > us :) ) so I'm looking for explanations on how you use the LEDs (visual debugging for
> > big-LITTLE was how Lorenzo was using them on TC2 for example).
Linus,
>
> OK now I feel bad and maybe I was not in such a good mood that day.
Don't worry, I actually found it amusing.
>
> The LEDs I added are really useful on the other ARM reference designs,
> the heartbeat gives a sign that the system is alive even if your console is
> not working and that's what I appreaciate a lot about it (the
> heartbeat intensity
> also indicates system load).
>
> The MMC read/write LED is as useful as the hard disk activity LED on
> some older PCs, kinda nice if you want to know something is going on.
>
> The rest of the LEDs show which CPU cores are active. This was the
> original use of the LEDs on the RealView PB11MPcore and it was
> appreciated by the multicore developers who could see the different
> CPUs being busy with tasks.
In that case you might want to use the remaining 2 leds for cpus 4 and 5,
as Juno has a total of 6 cores. Your current patch leaves two LEDs unassigned.
>
> LEDs on development boards are real nice, simply, and I think also
> some deployed ARM64 server systems will have them.
Agree on LEDs being nice. I'm guessing that on server side if you want blinking lights
you need ACPI? ;)
Best regards,
Liviu
>
> Yours,
> Linus Walleij
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
?\_(?)_/?
next prev parent reply other threads:[~2015-03-09 10:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 12:16 [PATCH 1/2] arm64: juno: Add APB registers and LEDs using syscon Linus Walleij
2015-02-25 13:55 ` Will Deacon
2015-02-25 14:47 ` Liviu Dudau
2015-02-25 15:00 ` Will Deacon
2015-02-25 15:11 ` Liviu Dudau
2015-02-27 13:07 ` Linus Walleij
2015-02-27 14:06 ` Liviu Dudau
2015-03-07 22:24 ` Linus Walleij
2015-03-09 10:12 ` Liviu Dudau [this message]
2015-03-09 10:31 ` Sudeep Holla
2015-03-09 16:17 ` Jon Medhurst (Tixy)
2015-03-09 17:19 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309101205.GY16268@e106497-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).