From: rostedt@goodmis.org (Steven Rostedt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ring-buffer: Replace this_cpu_*() with __this_cpu_*()
Date: Thu, 19 Mar 2015 12:40:23 -0400 [thread overview]
Message-ID: <20150319124023.4c1b1094@gandalf.local.home> (raw)
In-Reply-To: <alpine.DEB.2.11.1503191130330.27377@gentwo.org>
On Thu, 19 Mar 2015 11:33:30 -0500 (CDT)
Christoph Lameter <cl@linux.com> wrote:
> If you are redoing it then please get the comments a bit cleared up. The
What comments should I clear up? This version did not have a comment.
It just switched this_cpu_* to __this_cpu_*, and also updated a
variable algorithm.
-- Steve
> heaviness of the fallback version of this_cpu_read/write can usually
> easily be remedied by arch specific definitions. The per cpu
> offset is somewhere in a register and one needs to define a macro that
> creates an instruction that does a fetch from that register plus
> the current offset into the area that is needed. This is similarly easy
> for the write path. But then its often easier to just use the __this_cpu
> instructions since preemption is often off in these code paths.
>
> I have had code for IA64 in the past that does this.
next prev parent reply other threads:[~2015-03-19 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 21:31 [RFC][PATCH] ring-buffer: Replace this_cpu_{read,write} with this_cpu_ptr() Steven Rostedt
2015-03-17 5:56 ` Christoph Lameter
2015-03-17 12:13 ` Steven Rostedt
2015-03-17 14:11 ` Steven Rostedt
2015-03-17 14:40 ` [PATCH v2] ring-buffer: Replace this_cpu_*() with __this_cpu_*() Steven Rostedt
2015-03-17 14:47 ` Uwe Kleine-König
2015-03-17 15:07 ` Steven Rostedt
2015-03-19 16:20 ` Christoph Lameter
2015-03-19 16:31 ` Steven Rostedt
2015-03-19 16:33 ` Christoph Lameter
2015-03-19 16:40 ` Steven Rostedt [this message]
2015-03-24 18:49 ` Christoph Lameter
2015-03-19 16:19 ` [RFC][PATCH] ring-buffer: Replace this_cpu_{read,write} with this_cpu_ptr() Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319124023.4c1b1094@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).