From: peter.griffin@linaro.org (Peter Griffin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios
Date: Tue, 1 Sep 2015 11:34:58 +0100 [thread overview]
Message-ID: <20150901103458.GA9149@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <CABxcv==iC+mkVGKi_9LSidPjFa2WTooARMCOcWW1Nyr80UYJgw@mail.gmail.com>
Hi Javier,
On Tue, 01 Sep 2015, Javier Martinez Canillas wrote:
> Hello Lee,
>
> On Tue, Sep 1, 2015 at 11:09 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Tue, 01 Sep 2015, Javier Martinez Canillas wrote:
> >> On Fri, Aug 28, 2015 at 7:52 PM, Peter Griffin <peter.griffin@linaro.org> wrote:
> >> > gpio.txt documents that GPIO properties should be named
> >> > "[<name>-]gpios", with <name> being the purpose of this
> >> > GPIO for the device.
> >> >
> >> > This change has been done as one atomic commit.
> >> >
> >> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> >> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >> > ---
> >> > Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt | 6 +++---
> >> > arch/arm/boot/dts/stihxxx-b2120.dtsi | 4 ++--
> >> > drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
> >> > 3 files changed, 6 insertions(+), 6 deletions(-)
> >> >
> >> > diff --git a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> >> > index d4def76..e70d840 100644
> >> > --- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> >> > +++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> >> > @@ -35,7 +35,7 @@ Required properties (tsin (child) node):
> >> >
> >> > - tsin-num : tsin id of the InputBlock (must be between 0 to 6)
> >> > - i2c-bus : phandle to the I2C bus DT node which the demodulators & tuners on this tsin channel are connected.
> >> > -- rst-gpio : reset gpio for this tsin channel.
> >> > +- reset-gpios : reset gpio for this tsin channel.
> >>
> >> The documentation is a bit outdated, the GPIO subsystem supports both
> >> -gpio and -gpios, see commit:
> >>
> >> dd34c37aa3e8 ("gpio: of: Allow -gpio suffix for property names")
> >>
> >> So it makes sense to me to use -gpio instead of -gpios in this case
> >> since is a single GPIO. Also rst is already a descriptive name since
> >> that's how many datasheets name a reset pin. I'm not saying I'm
> >> against this patch, just pointing out since the commit message is a
> >> bit misleading.
Ok thanks for pointing that out. It's nice to know the original binding was
actually OK.
> >
> > As I suggested this patch, I feel I must comment.
> >
> > My order of preference would be:
> >
> > reset-gpio
> > reset-gpios
> > rst-gpio
> > rst-gpios
> >
> > This current patch is No2, so it's okay to stay IMHO.
> >
>
> If the property is being changed anyways, why not going with No1 then?
I've changed to No1 in v4.
>
> As I said, I'm not against the patch but I think the commit message
> has to be reworded since implies that the problem is that the -gpio
> sufix is being used instead of -gpios. But since both are supported by
> the GPIO subsystem, the commit should mention that "reset" is more
> clear and easier to read than "rst" or something along those lines.
I've re-worded the commit message like you suggest in v4
>
> BTW, I just posted a patch for the GPIO doc to mention that -gpio is
> also supported:
>
> https://patchwork.kernel.org/patch/7103761/
Ok thanks for the pointer.
regards,
Peter.
next prev parent reply other threads:[~2015-09-01 10:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 17:52 [PATCH v3 0/6] [media] c8sectpfe: Various fixups Peter Griffin
2015-08-28 17:52 ` [PATCH v3 1/6] ARM: DT: STi: stihxxx-b2120: Add pulse-width properties to ssc2 & ssc3 Peter Griffin
2015-08-28 17:52 ` [PATCH v3 2/6] ARM: DT: STi: STiH407: Add c8sectpfe LinuxDVB DT node Peter Griffin
2015-09-01 7:59 ` Lee Jones
2015-08-28 17:52 ` [PATCH v3 3/6] [media] c8sectpfe: Remove select on undefined LIBELF_32 Peter Griffin
2015-08-28 17:52 ` [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Peter Griffin
2015-08-31 15:25 ` Rob Herring
2015-09-01 7:58 ` Lee Jones
2015-09-01 10:12 ` Peter Griffin
2015-09-01 8:32 ` Javier Martinez Canillas
2015-09-01 9:09 ` Lee Jones
2015-09-01 9:16 ` Javier Martinez Canillas
2015-09-01 9:25 ` Lee Jones
2015-09-01 10:34 ` Peter Griffin [this message]
2015-09-01 12:09 ` Lee Jones
2015-09-01 11:54 ` Rob Herring
2015-09-01 12:30 ` Javier Martinez Canillas
2015-09-02 15:03 ` Peter Griffin
2015-08-28 17:52 ` [PATCH v3 5/6] [media] c8sectpfe: Update DT binding doc with some minor fixes Peter Griffin
2015-08-28 17:52 ` [PATCH v3 6/6] [media] c8sectpfe: Simplify for loop in load_slim_core_fw Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901103458.GA9149@griffinp-ThinkPad-X1-Carbon-2nd \
--to=peter.griffin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).