From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64/apm: add dts for Gigabyte MP30-AR0 board
Date: Wed, 2 Sep 2015 14:57:53 +0100 [thread overview]
Message-ID: <20150902135753.GA15051@leverpostej> (raw)
In-Reply-To: <20150902075936.GR17056@jannau.net>
> > > +};
> > > diff --git a/arch/arm64/boot/dts/apm/mp30ar0.dts b/arch/arm64/boot/dts/apm/mp30ar0.dts
> > > new file mode 100644
> > > index 0000000..f7a9dae5
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/apm/mp30ar0.dts
>
> [...]
>
> > > + memory {
> > > + #address-cells = <0x2>;
> > > + #size-cells = <0x2>;
> >
> > I don't see why these properties should be here.
>
> removed
>
> > > + device_type = "memory";
> > > + reg = <0x0 0x0 0x0 0x2000000>;
> >
> > Is this overriden by the bootloader? It seems a tad small...
>
> yes, it is overriden by the bootloader. It requires a memory node in the
> dts but will overwrite the contents. I'll set size to zero and add a
> comment that it is updated by the bootloader. I could set start to 0x40
> 0x00 or leave it at zero.
I think all zeroes is preferable. The comment is definitely worthwhile.
> > > + };
> > > +
> > > + poweroff_mbox: poweroff_mbox at 10548000 {
> > > + compatible = "syscon";
> > > + reg = <0x0 0x10548000 0x0 0x100>;
> > > + };
> > > +
> > > + poweroff at 10548010 {
> > > + compatible = "syscon-poweroff";
> > > + regmap = <&poweroff_mbox>;
> > > + offset = <0x10>;
> > > + mask = <0x1>;
> > > + };
> > > +
> > > + chosen {
> > > + linux,stdout-path = "/soc/serial at 1c020000";
> >
> > Please use stdout-path rather than linux,stdout-path.
> >
> > No rate configuration?
> >
> > This would look nicer with an alias.
>
> I can change that but the bootloader will add a 'linux,stdout-path' and
> the stdout-path will override it. OTOH the bootloader seems to always
> add this exact string so it will be fine to "override" it from the dts.
> The alternative would to remove it.
I guess it doesn't fill in the rate, which is somewhat unfortunate.
Does it override an existing linux,stdout-path? If not, we could add the
rate.
I think we should have a comment about the bootlaoder filling in
linux,stdout-path, but other than that I'm not really sure what the best
option is.
Thanks,
Mark.
next prev parent reply other threads:[~2015-09-02 13:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 15:24 [arm64/apm] add support for the gigabyte mp30-ar0 board Janne Grunau
2015-08-30 15:24 ` [PATCH 1/2] arm64/apm: create X-Gene storm chip variant dtsi Janne Grunau
2015-08-30 15:24 ` [PATCH 2/2] arm64/apm: add dts for Gigabyte MP30-AR0 board Janne Grunau
2015-08-30 17:26 ` Janne Grunau
2015-09-01 10:55 ` Mark Rutland
2015-09-02 7:59 ` Janne Grunau
2015-09-02 13:57 ` Mark Rutland [this message]
2015-09-03 22:28 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902135753.GA15051@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).