From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: add kc_offset_to_vaddr and kc_vaddr_to_offset macro
Date: Fri, 4 Sep 2015 17:51:02 +0100 [thread overview]
Message-ID: <20150904165102.GA25257@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20150902102454.GG25720@arm.com>
On Wed, Sep 02, 2015 at 11:24:54AM +0100, Will Deacon wrote:
> On Sun, Aug 30, 2015 at 07:19:59AM +0100, yalin wang wrote:
> > This patch add kc_offset_to_vaddr() and kc_vaddr_to_offset(),
> > the default version doesn't work on arm64, because arm64 kernel address
> > is below the PAGE_OFFSET, like module address and vmemmap address are
> > all below PAGE_OFFSET address.
> >
> > Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> > ---
> > arch/arm64/include/asm/pgtable.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h
> > index d374191..ef1ed5c 100644
> > --- a/arch/arm64/include/asm/pgtable.h
> > +++ b/arch/arm64/include/asm/pgtable.h
> > @@ -660,6 +660,8 @@ static inline void update_mmu_cache(struct vm_area_struct *vma,
> >
> > #define update_mmu_cache_pmd(vma, address, pmd) do { } while (0)
> >
> > +#define kc_vaddr_to_offset(v) ((v) & ((1UL << VA_BITS) - 1))
> > +#define kc_offset_to_vaddr(o) ((o) | ~((1UL << VA_BITS) - 1))
>
> I think it would be cleaner to define something like VIRTUAL_BASE, and
> then define the vmalloc area in terms of that as well as these kcore
> macros.
The KASan patches were doing this, defining VA_START and defining
VMALLOC_START in terms of it. But they missed the merging window.
--
Catalin
next prev parent reply other threads:[~2015-09-04 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 6:19 [PATCH] arm64: add kc_offset_to_vaddr and kc_vaddr_to_offset macro yalin wang
2015-09-01 2:00 ` yalin wang
2015-09-02 10:24 ` Will Deacon
2015-09-04 16:51 ` Catalin Marinas [this message]
2015-09-06 4:05 ` yalin wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904165102.GA25257@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).