From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] memory: omap-gpmc: Add Kconfig option for debug
Date: Mon, 4 Jan 2016 09:02:06 -0800 [thread overview]
Message-ID: <20160104170206.GC12777@atomide.com> (raw)
In-Reply-To: <568662FC.9050206@gmail.com>
* Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [160101 03:29]:
> Hi Tony,
>
> On 21.05.2015 00:21, Tony Lindgren wrote:
> >We support decoding the bootloader values if DEBUG is defined.
> >But we also need to change the struct omap_hwmod flags to have
> >HWMOD_INIT_NO_RESET to avoid the GPMC being reset during the
> >boot. Otherwise just the default timings will be displayed
> >instead of the bootloader configured timings.
> >
> >This also allows us to clean up the various GPMC related
> >hwmod flags. For debugging, we only need HWMOD_INIT_NO_RESET,
> >and HWMOD_INIT_NO_IDLE is not needed.
> >
> >Cc: Brian Hutchinson <b.hutchman@gmail.com>
> >Cc: Paul Walmsley <paul@pwsan.com>
> >Cc: Roger Quadros <rogerq@ti.com>
> >Signed-off-by: Tony Lindgren <tony@atomide.com>
> >---
> > arch/arm/mach-omap2/omap_hwmod.h | 6 ++++++
> > arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 12 ++----------
> > arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 3 ++-
> > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 12 ++----------
> > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 11 ++---------
> > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 4 ++--
> > arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 2 ++
> > drivers/memory/Kconfig | 8 ++++++++
> > drivers/memory/omap-gpmc.c | 6 +++---
> > 9 files changed, 29 insertions(+), 35 deletions(-)
> >
>
> 1. Happy new year :)
Same to you :)
> 2. It was a while I tested upstream on N900 but I had some spare time during
> the holidays to play, so I tried to boot 4.4-rc6 with Maemo 5. To my
> surprise, after that try, Maemo 5 rootfs, which is located on onenand became
> irreversibly corrupted. I bisected the tree to the $subject commit and after
> restoring HWMOD_INIT_NO_RESET in omap3xxx_gpmc_hwmod flags, the problem was
> solved. It seems that GPMC is either incorrectly or incompletely setup by
> the kernel, leading to failed onenand reads/writes and whatnot.
> Unfortunately, what I have here is a release device, so I am unable to
> capture any logs through the serial port. BTW keep in mind that rootfs
> corruption happens as soon as a boot is attempted, even after a freshly
> flashed rootfs.
Oh crap, sorry to hear that :(
Care to boot with CONFIG_OMAP_GPMC_DEBUG=y and post the gpmc related dmesg
output? The dmesg timings with CONFIG_OMAP_GPMC_DEBUG enabled should be
compared against omap3-n900.dts gpmc timings. And if you don't see the whole
dmesg after booting, you may need to also increase CONFIG_LOG_BUF_SHIFT.
Meanwhile, I'll try to also produce it here.
Chances are we have bad or incomplete timings in the n900 :(
Regards,
Tony
next prev parent reply other threads:[~2016-01-04 17:02 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 21:21 [PATCH 0/2] omap gpmc changes for parsing devices and working debug Tony Lindgren
2015-05-20 21:21 ` [PATCH 1/2] memory: omap-gpmc: Fix parsing of devices Tony Lindgren
2015-05-20 21:21 ` [PATCH 2/2] memory: omap-gpmc: Add Kconfig option for debug Tony Lindgren
2015-05-20 22:50 ` Paul Walmsley
2015-05-20 22:56 ` Tony Lindgren
2015-05-21 1:06 ` Paul Walmsley
2015-08-27 6:25 ` Hannes Schmelzer
[not found] ` <OFCA2F1DCE.C787A961-ONC1257EAE.001D79BC-C1257EAE.00203AFF@br-automation.com>
2015-08-27 16:59 ` Tony Lindgren
2015-08-28 4:44 ` Hannes Schmelzer
2015-09-01 12:35 ` Roger Quadros
2015-09-01 13:31 ` Antwort: " Hannes Schmelzer
2015-09-02 14:43 ` Roger Quadros
2015-09-01 12:35 ` Roger Quadros
2016-01-01 11:29 ` Ivaylo Dimitrov
2016-01-04 17:02 ` Tony Lindgren [this message]
2016-01-04 17:34 ` Pali Rohár
2016-01-04 17:40 ` Tony Lindgren
2016-01-04 18:59 ` Ivaylo Dimitrov
2016-01-05 4:13 ` Tony Lindgren
2016-01-05 8:49 ` Pali Rohár
2016-01-05 22:49 ` Tony Lindgren
2016-01-06 8:55 ` Ivaylo Dimitrov
2016-01-06 9:05 ` Pali Rohár
2016-01-06 16:44 ` Tony Lindgren
2016-01-06 17:36 ` Aaro Koskinen
2016-01-06 17:40 ` Sebastian Reichel
2016-01-06 17:47 ` Tony Lindgren
2016-01-06 18:01 ` Ivaylo Dimitrov
2016-01-06 18:26 ` Tony Lindgren
2016-01-06 18:39 ` Ivaylo Dimitrov
2016-01-07 18:07 ` Tony Lindgren
2016-01-07 21:45 ` Ivaylo Dimitrov
2016-01-08 2:26 ` Tony Lindgren
2016-01-08 5:13 ` Ivaylo Dimitrov
2016-01-08 7:59 ` Pali Rohár
2016-01-09 0:23 ` Ivaylo Dimitrov
2016-01-21 9:14 ` Pali Rohár
2016-02-02 9:33 ` Ivaylo Dimitrov
2016-02-02 23:39 ` Tony Lindgren
2016-02-03 0:00 ` Tony Lindgren
2016-02-03 7:03 ` Ivaylo Dimitrov
2016-02-03 16:50 ` Ivaylo Dimitrov
2016-02-05 6:10 ` Tony Lindgren
2016-02-05 14:43 ` Ivaylo Dimitrov
2016-01-08 17:10 ` Tony Lindgren
2016-01-08 7:56 ` Pali Rohár
2016-01-08 17:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104170206.GC12777@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).