From: atomlin@redhat.com (Aaron Tomlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI
Date: Thu, 14 Apr 2016 16:19:33 +0100 [thread overview]
Message-ID: <20160414151933.GF20425@atomlin.usersys.redhat.com> (raw)
In-Reply-To: <1459877208-15119-3-git-send-email-cmetcalf@mellanox.com>
On Tue 2016-04-05 13:26 -0400, Chris Metcalf wrote:
> Currently on arm there is code that checks whether it should call
> dump_stack() explicitly, to avoid trying to raise an NMI when the
> current context is not preemptible by the backtrace IPI. Similarly,
> the forthcoming arch/tile support uses an IPI mechanism that does
> not support generating an NMI to self.
>
> Accordingly, move the code that guards this case into the generic
> mechanism, and invoke it unconditionally whenever we want a
> backtrace of the current cpu. It seems plausible that in all cases,
> dump_stack() will generate better information than generating a
> stack from the NMI handler. The register state will be missing,
> but that state is likely not particularly helpful in any case.
>
> Or, if we think it is helpful, we should be capturing and emitting
> the current register state in all cases when regs == NULL is passed
> to nmi_cpu_backtrace().
>
> Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
> ---
> arch/arm/kernel/smp.c | 9 ---------
> lib/nmi_backtrace.c | 9 +++++++++
> 2 files changed, 9 insertions(+), 9 deletions(-)
Thanks Chris.
Acked-by: Aaron Tomlin <atomlin@redhat.com>
--
Aaron Tomlin
next prev parent reply other threads:[~2016-04-14 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201604031905.WLWlnyKg%fengguang.wu@intel.com>
2016-04-05 17:26 ` [PATCH v5 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-04-05 17:26 ` [PATCH v5 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-04-14 15:17 ` Aaron Tomlin
2016-04-05 17:26 ` [PATCH v5 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-04-14 15:19 ` Aaron Tomlin [this message]
2016-04-05 17:26 ` [PATCH v5 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-07-13 18:44 ` [PATCH v5 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-07-14 20:50 ` [PATCH v6 " Chris Metcalf
2016-07-14 20:50 ` [PATCH v6 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-08-08 13:57 ` Petr Mladek
2016-08-08 15:49 ` Chris Metcalf
2016-07-14 20:50 ` [PATCH v6 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-07-14 20:50 ` [PATCH v6 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414151933.GF20425@atomlin.usersys.redhat.com \
--to=atomlin@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).