From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf/core / arm_pmu: special-case hetereogeneous CPUs
Date: Wed, 4 May 2016 14:46:42 +0100 [thread overview]
Message-ID: <20160504134641.GB31744@arm.com> (raw)
In-Reply-To: <20160504134419.GA15849@leverpostej>
On Wed, May 04, 2016 at 02:44:20PM +0100, Mark Rutland wrote:
> Hi,
>
> On Tue, Apr 26, 2016 at 11:33:46AM +0100, Mark Rutland wrote:
> > On Mon, Apr 25, 2016 at 09:03:34PM +0200, Peter Zijlstra wrote:
> > > On Mon, Apr 25, 2016 at 06:58:37PM +0100, Mark Rutland wrote:
> > > > Hi,
> > > >
> > > > When booting an arm64 defconfig linux-next (next-20160422) on an ARM
> > > > Juno system, I hit a WARN_ON_ONCE in perf_pmu_register (see backtrace at
> > > > the end of this email).
> > > >
> > > > This was introduced by commit 26657848502b7847 ("perf/core: Verify we
> > > > have a single perf_hw_context PMU") where we forcefully prevent multiple
> > > > PMUs from sharing perf_hw_context (with a warning), and force additional
> > > > PMUs to use perf_invalid_context.
> >
> > > > Are you happy to revert 26657848502b787 for the timebeing? Or to somehow
> > > > predicate the check such that it doesn't adversely affect those HW PMUs?
> > >
> > > I'm happy with a chicken bit for now, its already found two real issues,
> > > so I'd like to keep it.
> >
> > Ok, how about the below? (based on next-20160422).
>
> Peter, any thoughts?
>
> This is still an issue for us in next-20160504 (to which the patch still
> applies).
>
> Will, I assume that you're ok with the change to drivers/perf/arm_pmu.c.
Yes, they're pretty straighforward.
Will
next prev parent reply other threads:[~2016-05-04 13:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 17:58 linux-next: perf issue on big.LITTLE since 26657848502b7847 Mark Rutland
2016-04-25 19:03 ` Peter Zijlstra
2016-04-26 10:33 ` [PATCH] perf/core / arm_pmu: special-case hetereogeneous CPUs Mark Rutland
2016-05-04 13:44 ` Mark Rutland
2016-05-04 13:46 ` Will Deacon [this message]
2016-05-04 15:08 ` Peter Zijlstra
2016-05-04 15:26 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504134641.GB31744@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).