From: jpoimboe@redhat.com (Josh Poimboeuf)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] arm64: implement FTRACE_WITH_REGS
Date: Fri, 1 Jul 2016 07:53:44 -0500 [thread overview]
Message-ID: <20160701125344.usuovsvbpilzen4m@treble> (raw)
In-Reply-To: <20160627151717.BD25468D26@newverein.lst.de>
On Mon, Jun 27, 2016 at 05:17:17PM +0200, Torsten Duwe wrote:
> Once gcc is enhanced to optionally generate NOPs at the beginning
> of each function, like the concept proven in
> https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01671.html
> (sans the "fprintf (... pad_size);", which spoils the data structure
> for kernel use), the generated pads can nicely be used to reroute
> function calls for tracing/profiling, or live patching.
>
> The pads look like
> fffffc00081335f0 <hrtimer_init>:
> fffffc00081335f0: d503201f nop
> fffffc00081335f4: d503201f nop
> fffffc00081335f8: a9bd7bfd stp x29, x30, [sp,#-48]!
> fffffc00081335fc: 910003fd mov x29, sp
> [...]
>
> This patch gets the pad locations from the compiler-generated
> __prolog_pads_loc into the _mcount_loc array, and provides the
> code patching functions to turn the pads at runtime into
>
> fffffc00081335f0 mov x9, x30
> fffffc00081335f4 bl 0xfffffc00080a08c0 <ftrace_caller>
> fffffc00081335f8 stp x29, x30, [sp,#-48]!
> fffffc00081335fc mov x29, sp
>
> as well as an ftrace_caller that can handle these call sites.
> Now ARCH_SUPPORTS_FTRACE_OPS as a benefit, and the graph caller
> still works, too.
>
> Signed-off-by: Li Bin <huawei.libin@huawei.com>
> Signed-off-by: Torsten Duwe <duwe@suse.de>
> ---
> arch/arm64/Kconfig | 1 +
> arch/arm64/Makefile | 4 ++
> arch/arm64/include/asm/ftrace.h | 8 ++++
> arch/arm64/kernel/Makefile | 6 +--
> arch/arm64/kernel/entry-ftrace.S | 89 +++++++++++++++++++++++++++++++++++++++
> arch/arm64/kernel/ftrace.c | 43 +++++++++++++++++--
> include/asm-generic/vmlinux.lds.h | 2 +-
> include/linux/compiler.h | 4 ++
> 8 files changed, 150 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 5a0a691..36a0e26 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -72,6 +72,7 @@ config ARM64
> select HAVE_DMA_API_DEBUG
> select HAVE_DMA_CONTIGUOUS
> select HAVE_DYNAMIC_FTRACE
> + select HAVE_DYNAMIC_FTRACE_WITH_REGS
> select HAVE_EFFICIENT_UNALIGNED_ACCESS
> select HAVE_FTRACE_MCOUNT_RECORD
> select HAVE_FUNCTION_TRACER
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 648a32c..e5e335c 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -35,6 +35,10 @@ KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
> KBUILD_CFLAGS += $(call cc-option, -mpc-relative-literal-loads)
> KBUILD_AFLAGS += $(lseinstr)
>
> +ifeq ($(CONFIG_DYNAMIC_FTRACE_WITH_REGS), y)
> +CC_FLAGS_FTRACE := -fprolog-pad=2 -DCC_USING_PROLOG_PAD
> +endif
> +
It would probably be good to print a warning for older gccs which don't
support this option, so that when the build fails, there's at least a
warning to indicate why. Something like:
ifdef CONFIG_DYNAMIC_FTRACE_WITH_REGS
CC_FLAGS_FTRACE := -fprolog-pad=2 -DCC_USING_PROLOG_PAD
ifeq ($(call cc-option,-fprolog-pad=2),)
$(warning Cannot use CONFIG_DYNAMIC_FTRACE_WITH_REGS: \
-fprolog-pad not supported by compiler)
endif
endif
--
Josh
next prev parent reply other threads:[~2016-07-01 12:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 15:15 [PATCH v2 0/2] arm64 live patching Torsten Duwe
2016-06-27 15:17 ` [PATCH v2 1/2] arm64: implement FTRACE_WITH_REGS Torsten Duwe
2016-07-01 12:53 ` Josh Poimboeuf [this message]
2016-07-04 9:18 ` Torsten Duwe
2016-07-03 5:17 ` kbuild test robot
2016-07-08 14:58 ` Petr Mladek
2016-07-08 15:07 ` Torsten Duwe
2016-07-08 15:24 ` Petr Mladek
2016-07-08 15:48 ` Josh Poimboeuf
2016-07-08 15:57 ` Steven Rostedt
2016-07-08 20:24 ` Torsten Duwe
2016-07-08 21:08 ` Steven Rostedt
2016-07-09 9:06 ` Torsten Duwe
2016-07-15 18:36 ` Steven Rostedt
2016-07-08 15:49 ` Steven Rostedt
2016-06-27 15:17 ` [PATCH v2 2/2] arm64: implement live patching Torsten Duwe
2016-07-11 14:03 ` Miroslav Benes
2016-07-11 21:58 ` Jessica Yu
2016-07-12 9:47 ` Miroslav Benes
2016-07-13 0:11 ` [PATCH] arm64: take SHN_LIVEPATCH syms into account when calculating plt_max_entries Jessica Yu
2016-08-17 9:38 ` Miroslav Benes
2016-08-11 16:46 ` [PATCH v2 2/2] arm64: implement live patching Torsten Duwe
2016-07-15 16:03 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701125344.usuovsvbpilzen4m@treble \
--to=jpoimboe@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).