From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/15] ARM: dts: sun8i: Add dt node for rtl8703as wifi chip on ga10h
Date: Wed, 13 Jul 2016 09:18:44 +0200 [thread overview]
Message-ID: <20160713071844.GB4761@lukather> (raw)
In-Reply-To: <f5f0a0d0-96a8-e9ad-7b4d-b8f19999f0e9@redhat.com>
On Mon, Jul 11, 2016 at 02:36:43PM +0200, Hans de Goede wrote:
> >>+&mmc1 {
> >>+ pinctrl-names = "default";
> >>+ pinctrl-0 = <&mmc1_pins_a>;
> >>+ vmmc-supply = <®_dldo1>;
> >>+ bus-width = <4>;
> >>+ non-removable;
> >>+ status = "okay";
> >>+
> >>+ rtl8703as: sdio_wifi at 1 {
> >
> >Shouldn't that need a compatible ?
>
> There is no upstream driver yet, so no devicetree binding for the specific
> wifi chip used. But all we really need is to follow generic sdio / network
> bindings:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mmc/mmc-card.txt
>
> Describes how to create a mmc-host child-node describing an (e)mmc-card or
> sdio-function, in this case we are adding a node for sdio-function 1,
> hence the reg = <1>; in the child-node.
Both that file and
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mmc/mmc.txt
list the compatible property as mandatory.
>
> Linux implementation wise, this will make the mmc core set the dev->of_node
> ptr to this node for the struct device it passes into the sdio-drivers
> probe function.
>
> And u-boot will add a local-mac-address property as documented here:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/ethernet.txt
>
> to the node pointed to by ethernet%d aliases.
>
> To actually make use of this I've modified the out of tree driver to check
> for the "local-mac-address" property:
>
> https://github.com/jwrdegoede/rtl8723bs/commit/be5e87ea71677120ede457213208902ed9942653
>
> So that each device actually gets a unique address rather then the
> (stupid) behavior of the out of tree driver to set the same fixes
> mac address on every device which does not have a mac address in
> eeprom / nvram.
>
> Since this follows the existing ethernet bindings standard I
> believe the dts bits can go upstream as is, but since there
> is no upstream-able driver yet, I do not believe that making up
> a compatible string to add to the child-node is a good idea.
>
> More-over on q8 tablets we will want to do the same (again for
> eeprom / nvram less boards) but without pinning ourselves to
> a specific sdio-wifi module / compatible, instead relying on
> sdio enumeration to figure out which sdio-wifi module is present.
Feel free to raise that issue to the DT maintainers. But this patch
breaks the existing bindings, so it cannot be merged as is.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160713/b9fe20fb/attachment.sig>
next prev parent reply other threads:[~2016-07-13 7:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 16:05 [PATCH 00/15] ARM: dts: sunxi: Add reference-design-tablet.dtsi files + 2 new tablets Hans de Goede
2016-07-08 16:05 ` [PATCH 01/15] ARM: dts: sunxi: Rename sunxi-q8-common.dtsi sunxi-reference-design-tablet.dtsi Hans de Goede
2016-07-08 16:05 ` [PATCH 02/15] ARM: dts: sun5i: Move q8 display bits to sun5i-a13-q8-tablet.dts Hans de Goede
2016-07-08 16:05 ` [PATCH 03/15] ARM: dts: sun5i: Rename sun5i-q8-common.dtsi sun5i-reference-design-tablet.dtsi Hans de Goede
2016-07-08 16:05 ` [PATCH 04/15] ARM: dts: sun5i: reference-design-tablet: Set lradc vref to avcc Hans de Goede
2016-07-08 16:05 ` [PATCH 05/15] ARM: dts: sun5i: reference-design-tablet: Remove mention of q8 Hans de Goede
2016-07-09 3:53 ` Chen-Yu Tsai
2016-07-09 9:28 ` Hans de Goede
2016-07-08 16:05 ` [PATCH 06/15] ARM: dts: sun5i: Use sun5i-reference-design-tablet.dtsi for dit4350 dts Hans de Goede
2016-07-08 16:05 ` [PATCH 07/15] ARM: dts: sun5i: Use sun5i-reference-design-tablet.dtsi for utoo p66 dts Hans de Goede
2016-07-08 16:05 ` [PATCH 08/15] ARM: dts: Copy sun8i-q8-common.dtsi sun8i-reference-design-tablet.dtsi Hans de Goede
2016-07-08 16:05 ` [PATCH 09/15] ARM: dts: sun8i: reference-design-tablet: Add drivevbus-supply Hans de Goede
2016-07-08 16:05 ` [PATCH 10/15] ARM: dts: sun8i: Use sun8i-reference-design-tablet for polaroid mid2809pxe04 Hans de Goede
2016-07-08 16:05 ` [PATCH 11/15] ARM: dts: sun8i: Use sun8i-reference-design-tablet for gt90h dts Hans de Goede
2016-07-08 16:05 ` [PATCH 12/15] ARM: dts: sun8i: Use sun8i-reference-design-tablet for ga10h dts Hans de Goede
2016-07-08 16:05 ` [PATCH 13/15] ARM: dts: sun8i: Add dt node for rtl8703as wifi chip on ga10h Hans de Goede
2016-07-11 6:39 ` Maxime Ripard
2016-07-11 12:36 ` Hans de Goede
2016-07-13 7:18 ` Maxime Ripard [this message]
2016-07-08 16:05 ` [PATCH 14/15] ARM: dts: sun8i: Add dts file for Polaroid MID2407PXE03 tablet Hans de Goede
2016-07-08 16:05 ` [PATCH 15/15] ARM: dts: sun8i: Add dts file for inet86dz board Hans de Goede
2016-07-11 6:39 ` [PATCH 00/15] ARM: dts: sunxi: Add reference-design-tablet.dtsi files + 2 new tablets Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160713071844.GB4761@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).