From mboxrd@z Thu Jan 1 00:00:00 1970 From: hzpeterchen@gmail.com (Peter Chen) Date: Fri, 15 Jul 2016 15:13:09 +0800 Subject: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver In-Reply-To: References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-2-git-send-email-rajesh.bhagat@nxp.com> <20160711064358.GG31647@shlinux2> Message-ID: <20160715071309.GF817@shlinux2> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote: > > > + > > > +err_clks: > > > + ci_hdrc_qoriq_disable_unprepare_clks(pdev); > > > > If you have only one clock, it is unnecessary to use dedicated APIs for clock operation. > > > > We do have multiple clocks, but currently one is integrated in code. Hence created > the APIs for future use. If you could not integrate one more clocks, I suggest not creating dedicated API until you need in future. -- Best Regards, Peter Chen